You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/04 13:05:40 UTC
[GitHub] [camel-quarkus] aldettinger opened a new pull request, #3959: Merge the performance regression detection prototype #3905
aldettinger opened a new pull request, #3959:
URL: https://github.com/apache/camel-quarkus/pull/3959
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3959: Merge the performance regression detection prototype #3905
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #3959:
URL: https://github.com/apache/camel-quarkus/pull/3959#issuecomment-1205404850
> @aldettinger is it possible to reuse such `mvnw` in the root directory?
@zhfeng Thanks for feedback. It looks that the root mvnw has a far more recent version. So we should probably align on this one if feasible, and probably we can remove the .mvn folder after that.
I would take it as a dedicated task in another ticket. What do you think ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3959: Merge the performance regression detection prototype #3905
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #3959:
URL: https://github.com/apache/camel-quarkus/pull/3959#issuecomment-1208386853
Ok, I'm gonna merge this one then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3959: Merge the performance regression detection prototype #3905
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #3959:
URL: https://github.com/apache/camel-quarkus/pull/3959#issuecomment-1207834648
Another pair of eyes on this subject ? Feel welcome to ask questions if something is not clear enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #3959: Merge the performance regression detection prototype #3905
Posted by GitBox <gi...@apache.org>.
zhfeng commented on PR #3959:
URL: https://github.com/apache/camel-quarkus/pull/3959#issuecomment-1205940822
yeah, it looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3959: Merge the performance regression detection prototype #3905
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #3959:
URL: https://github.com/apache/camel-quarkus/pull/3959#issuecomment-1208386535
@jamesnetherton The wrapper version is next on my list #3960. And yes, we could also add some improvements like integrating the tool in the release process #3967.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #3959: Merge the performance regression detection prototype #3905
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on PR #3959:
URL: https://github.com/apache/camel-quarkus/pull/3959#issuecomment-1207845489
It looks mostly ok to me.
A nitpick on the Maven Wrapper. If we are going to (at least temporarily) have the sample project use its own wrapper, we should probably make sure the version is aligned with the one used by CQ.
Also, do you think we should add a dedicated docs page for this? I.e perhaps eventually it'd be part of the release process to do a perf check, so we could link to the relevant bits from the release guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3959: Merge the performance regression detection prototype #3905
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #3959:
URL: https://github.com/apache/camel-quarkus/pull/3959#issuecomment-1206131108
> yeah, it looks good to me.
Ok, I've filed #3960 in this respect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger merged pull request #3959: Merge the performance regression detection prototype #3905
Posted by GitBox <gi...@apache.org>.
aldettinger merged PR #3959:
URL: https://github.com/apache/camel-quarkus/pull/3959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org