You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/27 22:39:52 UTC
[GitHub] dongjoon-hyun edited a comment on issue #23387:
[SPARK-26447][SQL]Allow OrcColumnarBatchReader to return less partition
columns
dongjoon-hyun edited a comment on issue #23387: [SPARK-26447][SQL]Allow OrcColumnarBatchReader to return less partition columns
URL: https://github.com/apache/spark/pull/23387#issuecomment-450244166
@cloud-fan and @gengliangwang .
Could you review and merge https://github.com/gengliangwang/spark/pull/3 to this PR?
This PR is claiming an improvement **by returning the required partition column values only**. We had better add the test coverage on the newly added logic here.
> IIUC this is just a code refactor now, nothing will be changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org