You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/09/30 07:08:28 UTC
[GitHub] [ignite] ptupitsyn commented on a change in pull request #9443: IGNITE-15602 Define and use a discovery port in the KubernetesConnect…
ptupitsyn commented on a change in pull request #9443:
URL: https://github.com/apache/ignite/pull/9443#discussion_r719117647
##########
File path: modules/kubernetes/src/main/java/org/apache/ignite/kubernetes/configuration/KubernetesConnectionConfiguration.java
##########
@@ -138,6 +141,24 @@ public boolean getIncludeNotReadyAddresses() {
return includeNotReadyAddresses;
}
+ /**
+ * Specifies the port which is returned to the caller to use for service discovery
Review comment:
```suggestion
* Specifies the port which is returned to the caller to use for service discovery.
```
##########
File path: modules/kubernetes/src/main/java/org/apache/ignite/kubernetes/configuration/KubernetesConnectionConfiguration.java
##########
@@ -138,6 +141,24 @@ public boolean getIncludeNotReadyAddresses() {
return includeNotReadyAddresses;
}
+ /**
+ * Specifies the port which is returned to the caller to use for service discovery
+ * defaults to 0
+ * @param discoveryPort Port to use for Kubernetes IP Finder
Review comment:
```suggestion
* @param discoveryPort Port to use for Kubernetes IP Finder.
```
##########
File path: modules/kubernetes/src/main/java/org/apache/ignite/kubernetes/configuration/KubernetesConnectionConfiguration.java
##########
@@ -138,6 +141,24 @@ public boolean getIncludeNotReadyAddresses() {
return includeNotReadyAddresses;
}
+ /**
+ * Specifies the port which is returned to the caller to use for service discovery
+ * defaults to 0
+ * @param discoveryPort Port to use for Kubernetes IP Finder
+ * @return {@code this} for chaining.
+ */
+ public KubernetesConnectionConfiguration setDiscoveryPort(int discoveryPort) {
+ this.discoveryPort = discoveryPort;
Review comment:
```suggestion
this.discoveryPort = discoveryPort;
```
##########
File path: modules/kubernetes/src/main/java/org/apache/ignite/kubernetes/configuration/KubernetesConnectionConfiguration.java
##########
@@ -138,6 +141,24 @@ public boolean getIncludeNotReadyAddresses() {
return includeNotReadyAddresses;
}
+ /**
+ * Specifies the port which is returned to the caller to use for service discovery
+ * defaults to 0
Review comment:
```suggestion
* Defaults to 0.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org