You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by suez1224 <gi...@git.apache.org> on 2018/01/18 01:43:36 UTC
[GitHub] flink pull request #5306: [FLINK-8390][security]remove unused integration te...
GitHub user suez1224 opened a pull request:
https://github.com/apache/flink/pull/5306
[FLINK-8390][security]remove unused integration test code
## What is the purpose of the change
Remove unused integration test code from the main code.
## Brief change log
- Remove unused integration test code
## Verifying this change
- Run RollingSinkSecuredITCase, YARNSessionFIFOSecuredITCase, Kafka09SecuredRunITCase, and all IT cases pass.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: ( no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: ( no)
## Documentation
- Does this pull request introduce a new feature? ( no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/suez1224/flink FLINK-8390
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5306.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5306
----
commit 8ded3878aa94a20dcdc0292a486111aab9c571b6
Author: Shuyi Chen <sh...@...>
Date: 2018-01-18T00:56:54Z
remove unused integration test code
----
---
[GitHub] flink pull request #5306: [FLINK-8390][security]remove unused integration te...
Posted by suez1224 <gi...@git.apache.org>.
Github user suez1224 closed the pull request at:
https://github.com/apache/flink/pull/5306
---
[GitHub] flink issue #5306: [FLINK-8390][security]remove unused integration test code
Posted by suez1224 <gi...@git.apache.org>.
Github user suez1224 commented on the issue:
https://github.com/apache/flink/pull/5306
@tillrohrmann you are right, I just checked. The test is not functioning as it should be. I'll fix it.
Can you take a look at https://github.com/apache/flink/pull/5172 if you have time?
---
[GitHub] flink issue #5306: [FLINK-8390][security]remove unused integration test code
Posted by suez1224 <gi...@git.apache.org>.
Github user suez1224 commented on the issue:
https://github.com/apache/flink/pull/5306
@zentol , you are right, https://issues.apache.org/jira/browse/FLINK-8286 already did the removal.
---