You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jena.apache.org by an...@apache.org on 2018/04/13 21:11:54 UTC

[05/10] jena git commit: JENA-1521: Only really close if non-transactional

JENA-1521: Only really close if non-transactional


Project: http://git-wip-us.apache.org/repos/asf/jena/repo
Commit: http://git-wip-us.apache.org/repos/asf/jena/commit/67b18af4
Tree: http://git-wip-us.apache.org/repos/asf/jena/tree/67b18af4
Diff: http://git-wip-us.apache.org/repos/asf/jena/diff/67b18af4

Branch: refs/heads/master
Commit: 67b18af43f54814f66f63c13866556b4256e459c
Parents: 246786a
Author: Andy Seaborne <an...@apache.org>
Authored: Fri Apr 13 14:31:51 2018 +0100
Committer: Andy Seaborne <an...@apache.org>
Committed: Fri Apr 13 14:31:51 2018 +0100

----------------------------------------------------------------------
 .../org/apache/jena/tdb/transaction/DatasetGraphTransaction.java | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/jena/blob/67b18af4/jena-tdb/src/main/java/org/apache/jena/tdb/transaction/DatasetGraphTransaction.java
----------------------------------------------------------------------
diff --git a/jena-tdb/src/main/java/org/apache/jena/tdb/transaction/DatasetGraphTransaction.java b/jena-tdb/src/main/java/org/apache/jena/tdb/transaction/DatasetGraphTransaction.java
index fbb851b..b90d8ec 100644
--- a/jena-tdb/src/main/java/org/apache/jena/tdb/transaction/DatasetGraphTransaction.java
+++ b/jena-tdb/src/main/java/org/apache/jena/tdb/transaction/DatasetGraphTransaction.java
@@ -290,14 +290,12 @@ import org.apache.jena.tdb.store.GraphTxnTDB ;
     protected void _close() {
         if ( isClosed )
             return ;
-        isClosed = true ;
-        
         if ( sConn.haveUsedInTransaction() ) {
             if ( isInTransaction() ) {
                 TDB.logInfo.warn("Attempt to close a DatasetGraphTransaction while a transaction is active - ignored close (" + getLocation() + ")") ;
                 return ;
             }
-            // Otherwise ignore - there might be other transactions aronud.
+            // Otherwise ignore - close() while transactional is meaningless.
             return ;
         }
         synchronized(this) {