[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5552: HDFS-16979. RBF: Add dfsrouter port in hdfsauditlog

["ayushtkn (via GitHub)" <gi...@apache.org>]

ayushtkn commented on code in PR #5552:
URL: https://github.com/apache/hadoop/pull/5552#discussion_r1184829824


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java:
##########
@@ -50,7 +50,8 @@ public final class CallerContext {
   public static final String CLIENT_ID_STR = "clientId";
   public static final String CLIENT_CALL_ID_STR = "clientCallId";
   public static final String REAL_USER_STR = "realUser";
-
+  public static final String IS_DFSROUTER = "isDfsRouter";
+  public static final String DFSROUTER_PORT_STR = "dfsRouterPort";

Review Comment:
   There is no point having dfsRouterPort or is isDfsRouter, the code is very generic and adding Router specific code should be the last thing to do in the Namenode, Namenode doesn't care  whether router is proxying or any xyz client or service is proxying.
   
   Change it to be generic Proxy Client port nothing exactly router specific in the Namenode



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org