You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/09/08 20:49:26 UTC

[GitHub] [hudi] umehrot2 commented on pull request #6637: Fix AWSDmsAvroPayload#getInsertValue,combineAndGetUpdateValue to invo…

umehrot2 commented on PR #6637:
URL: https://github.com/apache/hudi/pull/6637#issuecomment-1241218981

   Fix LGTM.
   However, we should not be adding this whole end to end test in `TestCOWDataSource` and `TestMORDataSource`. These tests are there to test overall datasource related functionality, and should not really be used to test something so specific as DMS payload. There should be no need to run an entire end to end test to discover this issue.
   
   There is a `TestAWSDmsAvroPayload` class. We should understand why tests in that class did not catch the issue, and just modify them or add a new test as needed to be able to catch this issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org