You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/06/06 21:12:11 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #6572: Move `JoinType` and `JoinCondition` to datafusion_common
alamb opened a new pull request, #6572:
URL: https://github.com/apache/arrow-datafusion/pull/6572
# Which issue does this PR close?
Part of https://github.com/apache/arrow-datafusion/issues/1754 (see https://github.com/apache/arrow-datafusion/issues/1754#issuecomment-1579410979)
# Rationale for this change
I am trying to extract `physical_plan` into its own crate to improve modularity and compile times
`JoinType` and related structures to are used in physical_plan and I would like to avoid physical_plan depending on the logical plans
# What changes are included in this PR?
1. Move `JoinType` and `JoinCondition` to `datafusion_common`
2. Update use paths
# Are these changes tested?
Existing tests
# Are there any user-facing changes?
No, I left a backwards compatible `pub use`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6572: Move `JoinType` and `JoinCondition` to datafusion_common
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6572:
URL: https://github.com/apache/arrow-datafusion/pull/6572#discussion_r1220377686
##########
datafusion/core/src/physical_plan/joins/hash_join.rs:
##########
@@ -57,7 +57,6 @@ use crate::arrow::array::BooleanBufferBuilder;
use crate::arrow::datatypes::TimeUnit;
use crate::error::{DataFusionError, Result};
use crate::execution::{context::TaskContext, memory_pool::MemoryConsumer};
-use crate::logical_expr::JoinType;
Review Comment:
The point of this PR is to remove the `logical_expr` uses from `physical_plan`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6572: Move `JoinType` and `JoinCondition` to `datafusion_common`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6572:
URL: https://github.com/apache/arrow-datafusion/pull/6572#issuecomment-1580806902
Thank you for the review @Dandandan !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #6572: Move `JoinType` and `JoinCondition` to `datafusion_common`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6572:
URL: https://github.com/apache/arrow-datafusion/pull/6572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org