You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/06/19 17:48:53 UTC

Review Request 35650: NodeManager fail to start when secure mode enabled (hadoop_conf_dir set directly)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35650/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-12020
    https://issues.apache.org/jira/browse/AMBARI-12020


Repository: ambari


Description
-------

For yarn, params_linux was directly setting the hadoop_conf_dir which is calculated earlier in the file.  When configure() was called, the incorrect directory was used to write configs, and NodeManager would fail to start because containers-executor.cfg was missing.


Diffs
-----

  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py f017bbb 

Diff: https://reviews.apache.org/r/35650/diff/


Testing
-------

No new tests.  Existing sufficiently cover.

Manual testing verified on both secure and insecure clusters

----------------------------------------------------------------------
Total run:762
Total errors:0
Total failures:0
OK


Thanks,

Nate Cole


Re: Review Request 35650: NodeManager fail to start when secure mode enabled (hadoop_conf_dir set directly)

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35650/#review88543
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On June 19, 2015, 11:48 a.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35650/
> -----------------------------------------------------------
> 
> (Updated June 19, 2015, 11:48 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-12020
>     https://issues.apache.org/jira/browse/AMBARI-12020
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> For yarn, params_linux was directly setting the hadoop_conf_dir which is calculated earlier in the file.  When configure() was called, the incorrect directory was used to write configs, and NodeManager would fail to start because containers-executor.cfg was missing.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py f017bbb 
> 
> Diff: https://reviews.apache.org/r/35650/diff/
> 
> 
> Testing
> -------
> 
> No new tests.  Existing sufficiently cover.
> 
> Manual testing verified on both secure and insecure clusters
> 
> ----------------------------------------------------------------------
> Total run:762
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Nate Cole
> 
>