You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2024/02/25 05:58:49 UTC
[PR] chore: Remove the deprecation of statefulMapConcat operator. [incubator-pekko]
He-Pin opened a new pull request, #1147:
URL: https://github.com/apache/incubator-pekko/pull/1147
Motivation:
As reported in refs:https://github.com/apache/incubator-pekko/issues/1141 , the current `statefulMap` will introduce some overhead from the allocation of tuple `(State, Out)`. So let's just keep it before we come up with an allocation free version like JDK 22's gather api.
Result:
Remove the deprecation of `statefulMapConcat`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Remove the deprecation of statefulMapConcat operator. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #1147:
URL: https://github.com/apache/incubator-pekko/pull/1147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Remove the deprecation of statefulMapConcat operator. [incubator-pekko]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #1147:
URL: https://github.com/apache/incubator-pekko/pull/1147#issuecomment-1966023914
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Remove the deprecation of statefulMapConcat operator. [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1147:
URL: https://github.com/apache/incubator-pekko/pull/1147#discussion_r1504217558
##########
docs/src/main/paradox/stream/operators/Source-or-Flow/statefulMapConcat.md:
##########
@@ -6,7 +6,7 @@ Transform each element into zero or more elements that are individually passed d
@@@ warning
-The `statefulMapConcat` operator has been deprecated.
+The `statefulMapConcat` operator doesn't handle upstream's completion signal since the state kept in the closure can be lost.
Review Comment:
I think I might be able to come up with a fuller description later today or tomorrow. Could we hold off on merging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Remove the deprecation of statefulMapConcat operator. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1147:
URL: https://github.com/apache/incubator-pekko/pull/1147#discussion_r1504670772
##########
docs/src/main/paradox/stream/operators/Source-or-Flow/statefulMapConcat.md:
##########
@@ -6,7 +6,7 @@ Transform each element into zero or more elements that are individually passed d
@@@ warning
-The `statefulMapConcat` operator has been deprecated.
+The `statefulMapConcat` operator doesn't handle upstream's completion signal since the state kept in the closure can be lost.
Review Comment:
Please change directly on this pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Remove the deprecation of statefulMapConcat operator. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1147:
URL: https://github.com/apache/incubator-pekko/pull/1147#issuecomment-1965846866
@pjfanning PTAL, I will backport this once got merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org