You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/12/14 11:42:52 UTC
[PR] [SPARK-45005][PS][TESTS][FOLLOWUPS] Deduplicate `test_properties` [spark]
zhengruifeng opened a new pull request, #44353:
URL: https://github.com/apache/spark/pull/44353
### What changes were proposed in this pull request?
`test_properties` in `pyspark.pandas.tests.indexes.test_datetime` was moved to `pyspark.pandas.tests.indexes.test_datetime_property` in https://github.com/apache/spark/commit/c76e3f61dd7b56dbff43bba7144df939c03f0f66 , but that commit forgot to remove it in `pyspark.pandas.tests.indexes.test_datetime`, so `test_properties` and its parity test are tested twice.
### Why are the changes needed?
deduplicate test
### Does this PR introduce _any_ user-facing change?
no, test-only
### How was this patch tested?
ci
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45005][PS][TESTS][FOLLOWUPS] Deduplicate `test_properties` [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #44353:
URL: https://github.com/apache/spark/pull/44353#issuecomment-1857124428
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45005][PS][TESTS][FOLLOWUPS] Deduplicate `test_properties` [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #44353:
URL: https://github.com/apache/spark/pull/44353#issuecomment-1855695703
@itholic @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45005][PS][TESTS][FOLLOWUPS] Deduplicate `test_properties` [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #44353: [SPARK-45005][PS][TESTS][FOLLOWUPS] Deduplicate `test_properties`
URL: https://github.com/apache/spark/pull/44353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org