You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/07/29 04:58:36 UTC

[GitHub] [calcite] hsyuan commented on a change in pull request #1335: [CALCITE-3159] Distinct can be removed for MIN/MAX/BIT_OR/BIT_AND agg…

hsyuan commented on a change in pull request #1335: [CALCITE-3159] Distinct can be removed for MIN/MAX/BIT_OR/BIT_AND agg…
URL: https://github.com/apache/calcite/pull/1335#discussion_r308055441
 
 

 ##########
 File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
 ##########
 @@ -1025,28 +1025,17 @@ GROUP BY sal]]>
         </Resource>
         <Resource name="planBefore">
             <![CDATA[
-LogicalAggregate(group=[{0}], EXPR$1=[SUM($1)], EXPR$2=[MIN(DISTINCT $1)], EXPR$3=[SUM(DISTINCT $0)])
+LogicalAggregate(group=[{0}], EXPR$1=[SUM($1)], EXPR$2=[MIN($1)], EXPR$3=[SUM(DISTINCT $0)])
 
 Review comment:
   Can you add another test that has multiple DISTINCTs, but can't be reduced? like `SUM(DISTINCT comm), SUM(DISTINCT sal)`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services