You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by ch...@apache.org on 2008/11/01 16:01:36 UTC

svn commit: r709708 - in /httpd/httpd/trunk: include/ap_mmn.h include/mod_auth.h modules/aaa/mod_authz_owner.c

Author: chrisd
Date: Sat Nov  1 08:01:35 2008
New Revision: 709708

URL: http://svn.apache.org/viewvc?rev=709708&view=rev
Log:
remove unused AUTHZ_GROUP_NOTE define

Modified:
    httpd/httpd/trunk/include/ap_mmn.h
    httpd/httpd/trunk/include/mod_auth.h
    httpd/httpd/trunk/modules/aaa/mod_authz_owner.c

Modified: httpd/httpd/trunk/include/ap_mmn.h
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/ap_mmn.h?rev=709708&r1=709707&r2=709708&view=diff
==============================================================================
--- httpd/httpd/trunk/include/ap_mmn.h (original)
+++ httpd/httpd/trunk/include/ap_mmn.h Sat Nov  1 08:01:35 2008
@@ -171,6 +171,7 @@
  * 20080920.0 (2.3.0-dev)  Add ap_mpm_register_timed_callback.
  * 20080920.1 (2.3.0-dev)  Export mod_rewrite.h in the public API.
  * 20080920.2 (2.3.0-dev)  Added ap_timeout_parameter_parse to util.c / httpd.h
+ * 20080920.3 (2.3.0-dev)  Remove unused AUTHZ_GROUP_NOTE define.
  *
  */
 
@@ -179,7 +180,7 @@
 #ifndef MODULE_MAGIC_NUMBER_MAJOR
 #define MODULE_MAGIC_NUMBER_MAJOR 20080920
 #endif
-#define MODULE_MAGIC_NUMBER_MINOR 2                     /* 0...n */
+#define MODULE_MAGIC_NUMBER_MINOR 3                     /* 0...n */
 
 /**
  * Determine if the server's current MODULE_MAGIC_NUMBER is at least a

Modified: httpd/httpd/trunk/include/mod_auth.h
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/mod_auth.h?rev=709708&r1=709707&r2=709708&view=diff
==============================================================================
--- httpd/httpd/trunk/include/mod_auth.h (original)
+++ httpd/httpd/trunk/include/mod_auth.h Sat Nov  1 08:01:35 2008
@@ -42,7 +42,6 @@
 #define AUTHZ_PROVIDER_VERSION "0"
 #define AUTHN_DEFAULT_PROVIDER "file"
 
-#define AUTHZ_GROUP_NOTE "authz_group_note"
 #define AUTHN_PROVIDER_NAME_NOTE "authn_provider_name"
 #define AUTHZ_PROVIDER_NAME_NOTE "authz_provider_name"
 #define AUTHZ_ACCESS_PASSED_NOTE "authz_access_passed"

Modified: httpd/httpd/trunk/modules/aaa/mod_authz_owner.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/aaa/mod_authz_owner.c?rev=709708&r1=709707&r2=709708&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/aaa/mod_authz_owner.c (original)
+++ httpd/httpd/trunk/modules/aaa/mod_authz_owner.c Sat Nov  1 08:01:35 2008
@@ -27,7 +27,7 @@
 #include "http_protocol.h"
 #include "http_request.h"
 
-#include "mod_auth.h"     /* for AUTHZ_GROUP_NOTE */
+#include "mod_auth.h"
 
 APR_DECLARE_OPTIONAL_FN(char*, authz_owner_get_file_group, (request_rec *r));
 



Re: svn commit: r709708 - in /httpd/httpd/trunk: include/ap_mmn.h include/mod_auth.h modules/aaa/mod_authz_owner.c

Posted by Chris Darroch <ch...@pearsoncmg.com>.
Ruediger Pluem wrote:

> IMHO this requires a major bump (no problem on trunk) and not only a minor one.

   Thanks for catching that and the missing apr_pcalloc() in mod_authz_core.c!

Chris.

-- 
GPG Key ID: 366A375B
GPG Key Fingerprint: 485E 5041 17E1 E2BB C263  E4DE C8E3 FA36 366A 375B


Re: svn commit: r709708 - in /httpd/httpd/trunk: include/ap_mmn.h include/mod_auth.h modules/aaa/mod_authz_owner.c

Posted by Ruediger Pluem <rp...@apache.org>.

On 11/01/2008 04:01 PM, chrisd@apache.org wrote:
> Author: chrisd
> Date: Sat Nov  1 08:01:35 2008
> New Revision: 709708
> 
> URL: http://svn.apache.org/viewvc?rev=709708&view=rev
> Log:
> remove unused AUTHZ_GROUP_NOTE define
> 
> Modified:
>     httpd/httpd/trunk/include/ap_mmn.h
>     httpd/httpd/trunk/include/mod_auth.h
>     httpd/httpd/trunk/modules/aaa/mod_authz_owner.c

IMHO this requires a major bump (no problem on trunk) and not only a minor one.

Regards

RĂ¼diger