You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openjpa.apache.org by pp...@apache.org on 2009/02/16 18:00:09 UTC
svn commit: r744966 - in /openjpa/trunk:
openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/PreparedQueryCacheImpl.java
openjpa-kernel/src/main/java/org/apache/openjpa/kernel/PreparedQueryCache.java
Author: ppoddar
Date: Mon Feb 16 17:00:07 2009
New Revision: 744966
URL: http://svn.apache.org/viewvc?rev=744966&view=rev
Log:
OPENJPA-703: Clean up unused varaibles in PreparedQueryCache implementaion and remove support for Class based keys kep as placeholder for finder queries.
Modified:
openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/PreparedQueryCacheImpl.java
openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/PreparedQueryCache.java
Modified: openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/PreparedQueryCacheImpl.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/PreparedQueryCacheImpl.java?rev=744966&r1=744965&r2=744966&view=diff
==============================================================================
--- openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/PreparedQueryCacheImpl.java (original)
+++ openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/PreparedQueryCacheImpl.java Mon Feb 16 17:00:07 2009
@@ -52,11 +52,8 @@
public class PreparedQueryCacheImpl implements PreparedQueryCache {
private static final String PATTERN_SEPARATOR = "\\;";
private static final String EXLUDED_BY_USER = "Excluded by user";
- private static final String JPQL = "javax.persistence.JPQL";
- private static final String SELECT = "SELECT ";
// Key: Query identifier
private final Map<String, PreparedQuery> _delegate;
- private final Map<Class, PreparedQuery> _finders;
// Key: Query identifier Value: Reason why excluded
private final Map<String, String> _uncachables;
private List<String> _exclusionPatterns;
@@ -67,7 +64,6 @@
public PreparedQueryCacheImpl() {
_delegate = new HashMap<String, PreparedQuery>();
- _finders = new HashMap<Class, PreparedQuery>();
_uncachables = new HashMap<String, String>();
_stats = new QueryStatistics.Default();
}
@@ -164,15 +160,6 @@
}
}
- public PreparedQuery get(Class c) {
- lock();
- try {
- return _finders.get(c);
- } finally {
- unlock();
- }
- }
-
public Boolean isCachable(String id) {
lock();
try {
Modified: openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/PreparedQueryCache.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/PreparedQueryCache.java?rev=744966&r1=744965&r2=744966&view=diff
==============================================================================
--- openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/PreparedQueryCache.java (original)
+++ openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/PreparedQueryCache.java Mon Feb 16 17:00:07 2009
@@ -129,13 +129,6 @@
public PreparedQuery get(String id);
/**
- * Get the PreparedQuery for the finder query of the given class.
- *
- * @param c class for which a find-by-primary-key query is looked up
- */
- public PreparedQuery get(Class c);
-
- /**
* Affirms if a PreparedQuery can be cached against the given key.
*
* @return Boolean.FALSE if the given key is explicitly marked before as not