[GitHub] [hive] szlta commented on a change in pull request #1159: HIVE-23741: Store CacheTags in the file cache level

[GitBox <gi...@apache.org>]

szlta commented on a change in pull request #1159:
URL: https://github.com/apache/hive/pull/1159#discussion_r444771962



##########
File path: llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheImpl.java
##########
@@ -305,10 +305,10 @@ private boolean lockBuffer(LlapDataBuffer buffer, boolean doNotifyPolicy) {
         long offset = ranges[i].getOffset() + baseOffset;
         assert buffer.declaredCachedLength == LlapDataBuffer.UNKNOWN_CACHED_LENGTH;
         buffer.declaredCachedLength = ranges[i].getLength();
-        buffer.setTag(tag);
         while (true) { // Overwhelmingly executes once, or maybe twice (replacing stale value).
           LlapDataBuffer oldVal = subCache.getCache().putIfAbsent(offset, buffer);
           if (oldVal == null) {
+            buffer.setFileCache(subCache);

Review comment:
       This sets the reference from buffer to filecache instance alright.
   But as far as I see this only happens when LowLevelCacheImpl is used, aka caching Orc files, how does this reference setting happen with the SerdeLowLevelCache (text based files)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org