You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "EliadCohen (via GitHub)" <gi...@apache.org> on 2023/06/28 18:26:00 UTC
[GitHub] [incubator-devlake] EliadCohen opened a new pull request, #5596: pr-type/bug-fix: [Partial] Removed env file mount from devlake container
EliadCohen opened a new pull request, #5596:
URL: https://github.com/apache/incubator-devlake/pull/5596
As per discussion in PR #5554
Referencing effort to teliminate the .env file usage
### ⚠️ Pre Checklist
> Please complete _ALL_ items in this checklist, and remove before submitting
- [x] I have read through the [Contributing Documentation](https://devlake.apache.org/community/).
- [ ] I have added relevant tests.
- [ ] I have added relevant documentation.
- [x] I will add labels to the PR, such as `pr-type/bug-fix`, `pr-type/feature-development`, etc.
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes.
Please fill out as many sections below as possible.
-->
### Summary
What does this PR do?
eliminate the mounting of the .env file from the devlake container as referenced in
the docker-compose-dev.yml file
### Does this close any open issues?
Bug #5474
### Screenshots
Include any relevant screenshots here.
### Other Information
As per discussion in previous PR #5554, crated one PR for fixing in 0.17
and this PR for fixing in main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh merged pull request #5596: pr-type/bug-fix: [Partial] Removed env file mount from devlake container
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh merged PR #5596:
URL: https://github.com/apache/incubator-devlake/pull/5596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on a diff in pull request #5596: pr-type/bug-fix: [Partial] Removed env file mount from devlake container
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on code in PR #5596:
URL: https://github.com/apache/incubator-devlake/pull/5596#discussion_r1245996332
##########
docker-compose-dev.yml:
##########
@@ -75,7 +75,6 @@ services:
- "127.0.0.1:8080:8080"
restart: always
volumes:
- - ./.env:/app/.env
Review Comment:
I think we should mount it as `env_file`, so the `ENCRYPTION_KEY` can be loaded into the container
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org