You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by Chris Kimpton <ki...@yahoo.com> on 2001/11/12 14:47:35 UTC
PortletStyleClass - used a bit too much now..
Hi (probably mainly to Paul),
The above skin class is now used quite a lot - it was originally
intended to be the style for each portlet.
It is now used in the column and row controls and more...
This means that styles such as borders appear around both the column
and each portlet.
I think it would be more flexible to split this out - perhaps a
ControlStyleClass that is used for the controls.
Is this ok?
Shall I submit a patch?
Thanks,
Chris
=====
Need somewhere to Live in London? - Then go to http://freeflats.com
__________________________________________________
Do You Yahoo!?
Find a job, post your resume.
http://careers.yahoo.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
test - please ignore
Posted by David Sean Taylor <da...@bluesunrise.com>.
new email client, im testing sorry....
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: PortletStyleClass - used a bit too much now..
Posted by Chris Kimpton <ki...@yahoo.com>.
Hi Paul,
> >
> > Another thing I noticed is the portlet title in
> > controls/html/jetspeed.vm is not <b> bold anymore. But it comes
> up
> > bold with the sample site - just not on my app ;-) Anyone have
> any
> > clues as to where that bold is being defined now.
> >
>
>
> The bolding was moved in to the TitleStyleClass. Would you like me
> to
> bold the title when the TitleTextColor is set.
>
...in which case its a bug in my code - so I'd say leave it - I'll
look into it some more.
Thanks,
Chris
=====
Need somewhere to Live in London? - Then go to http://freeflats.com
__________________________________________________
Do You Yahoo!?
Find a job, post your resume.
http://careers.yahoo.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: PortletStyleClass - used a bit too much now..
Posted by Paul Spencer <pa...@apache.org>.
Chris,
Chris Kimpton wrote:
> Hi,
>
> --- Paul Spencer <pa...@apache.org> wrote:
>
>>Chris,
>>I agree the class is used a lot. I will add a ControlStyleClass to
>>the
>>skin.
>>
>>I was also thinking about a SelectedTitleStyleClass. This class
>>would
>>be used for the selected tab or menu item.
>>
>>
>
> Sounds good to me - I've been putting off trying to change part ;-)
>
> And I think there is a bug in the same template - the title font html
> comes out like this:
>
> <font style="color:"#000000")>
I have fixed this. I will commit this later today.
>
> I think there is an extra quote in the middle that needs removing.
>
>
> Another thing I noticed is the portlet title in
> controls/html/jetspeed.vm is not <b> bold anymore. But it comes up
> bold with the sample site - just not on my app ;-) Anyone have any
> clues as to where that bold is being defined now.
>
The bolding was moved in to the TitleStyleClass. Would you like me to
bold the title when the TitleTextColor is set.
> Regards,
> Chris
>
> =====
> Need somewhere to Live in London? - Then go to http://freeflats.com
>
> __________________________________________________
> Do You Yahoo!?
> Find a job, post your resume.
> http://careers.yahoo.com
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: PortletStyleClass - used a bit too much now..
Posted by Chris Kimpton <ki...@yahoo.com>.
Hi,
--- Paul Spencer <pa...@apache.org> wrote:
> Chris,
> I agree the class is used a lot. I will add a ControlStyleClass to
> the
> skin.
>
> I was also thinking about a SelectedTitleStyleClass. This class
> would
> be used for the selected tab or menu item.
>
Sounds good to me - I've been putting off trying to change part ;-)
And I think there is a bug in the same template - the title font html
comes out like this:
<font style="color:"#000000")>
I think there is an extra quote in the middle that needs removing.
Another thing I noticed is the portlet title in
controls/html/jetspeed.vm is not <b> bold anymore. But it comes up
bold with the sample site - just not on my app ;-) Anyone have any
clues as to where that bold is being defined now.
Regards,
Chris
=====
Need somewhere to Live in London? - Then go to http://freeflats.com
__________________________________________________
Do You Yahoo!?
Find a job, post your resume.
http://careers.yahoo.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: PortletStyleClass - used a bit too much now..
Posted by Paul Spencer <pa...@apache.org>.
Chris,
I agree the class is used a lot. I will add a ControlStyleClass to the
skin.
I was also thinking about a SelectedTitleStyleClass. This class would
be used for the selected tab or menu item.
Paul Spencer
Chris Kimpton wrote:
> Hi (probably mainly to Paul),
>
> The above skin class is now used quite a lot - it was originally
> intended to be the style for each portlet.
>
> It is now used in the column and row controls and more...
>
> This means that styles such as borders appear around both the column
> and each portlet.
>
> I think it would be more flexible to split this out - perhaps a
> ControlStyleClass that is used for the controls.
>
> Is this ok?
>
> Shall I submit a patch?
>
> Thanks,
> Chris
>
> =====
> Need somewhere to Live in London? - Then go to http://freeflats.com
>
> __________________________________________________
> Do You Yahoo!?
> Find a job, post your resume.
> http://careers.yahoo.com
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>