[GitHub] [spark] itholic commented on a diff in pull request #41514: [SPARK-43684][SPARK-43685][SPARK-43686][SPARK-43691][CONNECT][PS] Fix `(NullOps|NumOps).(eq|ne)` for Spark Connect.

["itholic (via GitHub)" <gi...@apache.org>]

itholic commented on code in PR #41514:
URL: https://github.com/apache/spark/pull/41514#discussion_r1223720225


##########
python/pyspark/pandas/data_type_ops/null_ops.py:
##########
@@ -43,6 +43,22 @@ class NullOps(DataTypeOps):
     def pretty_name(self) -> str:
         return "nulls"
 
+    def eq(self, left: IndexOpsLike, right: Any) -> SeriesOrIndex:

Review Comment:
   Yeah, this PR already include the same issues in batch. There is `CategoricalOps.eq` is left as a similar operation, but we need further investigation since it has different issues.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org