You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Jason Royals (JIRA)" <ji...@codehaus.org> on 2009/01/07 05:40:19 UTC

[jira] Commented: (MRESOURCES-81) 2.3 escapes characters when filtering properties

    [ http://jira.codehaus.org/browse/MRESOURCES-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=160191#action_160191 ] 

Jason Royals commented on MRESOURCES-81:
----------------------------------------

I get the same error too, looks to be caused by MRESOURCES-42

Sometimes escaping the backslash is needed, and sometimes it is not, depending on what is being filtered.  In my situation I need to specify ${builddir} in an XML file which is filtered.  Now I get backslashes in the XML file where they were not before, and the build breaks because the library  that uses that XML file is not expecting all that extra escaping.

I wonder if there could be an optional element under the {{<resource>}} and {{<testResource>}}section of the pom to be able to control at a resources level how characters are escaped.  For example:

{code}
<resource>
    <directory>src/main/webapp/WEB-INF</directory>
    <filtering>true</filtering>
    <escape>NONE</escape>
    <includes>
        <include>**/*.xml</include>
    </includes>
    <targetPath>../POSPolicyService-FunctionalTest/WEB-INF</targetPath>
</resource>
{code}

Possible values could be NONE, JAVA (just escape the backslashes) and PROPERTY (escape colons and backslashes).

Thanks


> 2.3 escapes characters when filtering properties
> ------------------------------------------------
>
>                 Key: MRESOURCES-81
>                 URL: http://jira.codehaus.org/browse/MRESOURCES-81
>             Project: Maven 2.x Resources Plugin
>          Issue Type: Bug
>    Affects Versions: 2.3
>         Environment: Windows
>            Reporter: Paul Jackson
>
> When filtering a property additional escaping characters are inserted into the replacement text.  Here's an example pom snippett:
>     <profiles>
>         <profile>
>             <id>Automated-Testing-Windows</id>
>             <properties>
>                 <server.resource.type>nt</server.resource.type>
>                 <server.remote.base.dir>D:\\AutomatedTesting</server.remote.base.dir>
>                 <server.remote.temp.dir>${server.remote.base.dir}\\temp</server.remote.temp.dir>
>             </properties>
>         </profile>
>   <build>
>     <resources>
>       <resource>
>         <directory>src/main/resources/${server.resource.type}</directory>
>         <filtering>true</filtering>
>       </resource>
>     </resources>
>     <resources>
>     <plugins>
>       <plugin>
>         <artifactId>maven-resources-plugin</artifactId>
>         <version>2.3</version>
>         <executions>
>           <execution>
>             <id>resources</id>
>             <phase>process-resources</phase>
>             <goals>
>               <goal>resources</goal>
>             </goals>
>             <configuration>
>               <outputDirectory>${project.build.directory}/resources</outputDirectory>
>               <includeEmptyDirectories>true</includeEmptyDirectories>
>             </configuration>
>           </execution>
>         </executions>
>       </plugin>
>     </plugins>
>   </build>
> and the following line of text in a file in src\main\resources\nt
>  cd /d ${server.remote.temp.dir}
> Resources plug in version 2.2 filters this property as follows:
> cd /d D:\\AutomatedTesting\\temp
> Resources plug in version 2.3 filters this property differently:
> cd /d D\:\\\\AutomatedTesting\\\\temp
> Notice the extra backslashes inserted before each backslash (minor issue) and colon (major issue).  Is there a way to prevent maven from inserting these escape characters?
>  
> I also checked out 2.4-SNAPSHOT revision 732027 and observed the same behavior.
> Thanks,
> -Paul

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira