You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2016/04/06 22:26:54 UTC
Review Request 45834: Create Alert For Reporting Potential Issues
With Slow REST Responses
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45834/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Bugs: AMBARI-15745
https://issues.apache.org/jira/browse/AMBARI-15745
Repository: ambari
Description
-------
There are many factors which can influence the response rate of the REST API when the web client polls various endpoints:
- Database access problems
- Federated PropertyProvider delays
- Serialization Time of JSON
If the response rate of the REST API is poor, this can affect the overall UX of the product and produce a situation where Ambari doesn't seem to be responding.
There should be an alert which provides queries into various parts of Ambari in order to determine if response times are acceptable.
- This should be a {{SERVER}} side task
- If possible, the query should be made directly through the ResourceProvider framework to simulate a REST request. It should be made against the cluster endpoint since that's what is most likely polled.
- The alert should have configurable values for the threshold settings.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java c12cf6f
ambari-server/src/main/java/org/apache/ambari/server/alerts/AgentHeartbeatAlertRunnable.java 0611e23
ambari-server/src/main/java/org/apache/ambari/server/alerts/AlertRunnable.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/alerts/AmbariPerformanceRunnable.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/alerts/StaleAlertRunnable.java 54abd62
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ParameterizedSource.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ScriptSource.java 5871178
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ServerSource.java 30e73bc
ambari-server/src/main/java/org/apache/ambari/server/state/services/AmbariServerAlertService.java a13a8c7
ambari-server/src/main/resources/alerts.json e584b2c
ambari-server/src/test/java/org/apache/ambari/server/alerts/AgentHeartbeatAlertRunnableTest.java 673db7a
ambari-server/src/test/java/org/apache/ambari/server/alerts/StaleAlertRunnableTest.java 29b4ad5
Diff: https://reviews.apache.org/r/45834/diff/
Testing
-------
PENDING...
Thanks,
Jonathan Hurley
Re: Review Request 45834: Create Alert For Reporting Potential Issues
With Slow REST Responses
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45834/
-----------------------------------------------------------
(Updated April 7, 2016, 11:53 a.m.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Bugs: AMBARI-15745
https://issues.apache.org/jira/browse/AMBARI-15745
Repository: ambari
Description
-------
There are many factors which can influence the response rate of the REST API when the web client polls various endpoints:
- Database access problems
- Federated PropertyProvider delays
- Serialization Time of JSON
If the response rate of the REST API is poor, this can affect the overall UX of the product and produce a situation where Ambari doesn't seem to be responding.
There should be an alert which provides queries into various parts of Ambari in order to determine if response times are acceptable.
- This should be a {{SERVER}} side task
- If possible, the query should be made directly through the ResourceProvider framework to simulate a REST request. It should be made against the cluster endpoint since that's what is most likely polled.
- The alert should have configurable values for the threshold settings.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java c12cf6f
ambari-server/src/main/java/org/apache/ambari/server/alerts/AgentHeartbeatAlertRunnable.java 0611e23
ambari-server/src/main/java/org/apache/ambari/server/alerts/AlertRunnable.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/alerts/AmbariPerformanceRunnable.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/alerts/StaleAlertRunnable.java 54abd62
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ParameterizedSource.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ScriptSource.java 5871178
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ServerSource.java 30e73bc
ambari-server/src/main/java/org/apache/ambari/server/state/services/AmbariServerAlertService.java a13a8c7
ambari-server/src/main/resources/alerts.json e584b2c
ambari-server/src/test/java/org/apache/ambari/server/alerts/AgentHeartbeatAlertRunnableTest.java 673db7a
ambari-server/src/test/java/org/apache/ambari/server/alerts/AmbariPerformanceRunnableTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/alerts/StaleAlertRunnableTest.java 29b4ad5
Diff: https://reviews.apache.org/r/45834/diff/
Testing (updated)
-------
mvn clean test
Thanks,
Jonathan Hurley