You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/07/27 15:35:17 UTC

[GitHub] [logging-log4j2] carterkozak commented on a diff in pull request #974: LOG4J2-3560: Logger$PrivateConfig.filter(Level, Marker, String) varargs does not allocate

carterkozak commented on code in PR #974:
URL: https://github.com/apache/logging-log4j2/pull/974#discussion_r931213679


##########
src/changes/changes.xml:
##########
@@ -33,6 +33,9 @@
       <action issue="LOG4J2-3550" dev="rgoers" type="fix" due-to="DongjianPeng">
         SystemPropertyAribiter was assigning the value as the name.
       </action>
+      <action issue="LOG4J2-3560" dev="schlosna" type="fix">

Review Comment:
   I'll take care of this update prior to merging, the dev attribute reflects the committer who has signed off on the change while `due-to` provides attribution for the work if it wasn't generated by the committer.
   ```suggestion
         <action issue="LOG4J2-3560" dev="ckozak" type="fix" due-to="David Schlosnagle">
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org