[jira] [Commented] (HIVE-11575) Fix test failures in master due to log4j changes

["Prasanth Jayachandran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-11575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698892#comment-14698892 ] 

Prasanth Jayachandran commented on HIVE-11575:
----------------------------------------------

Setting hive.ql.log.PerfLogger.level in hiveconf object will never work as there is no such config in HiveConf.ConfVars. These configs are not converted to system properties unless passed through -hiveconf via hive cli. This setting is passed to old log4j.properties or new log4j2.xml only through system properties. If system property hive.ql.log.PerfLogger.level is set to "INFO,console" then all perf logger logs goes to the console. All arguments passed via -hiveconf is converted to system property automatically CommonCliOptions.addHiveconfToSystemProperties(). 

Following are the changes in the attached patch
1) removed setting of hive.ql.log.PerfLogger.level programmatically in hive config object or via hive-site.xml.
2) log4j2.xml is updated to get the logger and logger level via system property. By default, if nothing is specified perf logger is configured based on root logger  (which is the parent logger) and the child logger will be default (ERROR, Console)

This patch solves duplicate perflogger log lines in the log file (HIVE-11563) as well as the current test failures in master. 

> Fix test failures in master due to log4j changes
> ------------------------------------------------
>
>                 Key: HIVE-11575
>                 URL: https://issues.apache.org/jira/browse/HIVE-11575
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Logging
>    Affects Versions: 2.0.0
>            Reporter: Prasanth Jayachandran
>            Assignee: Prasanth Jayachandran
>             Fix For: 2.0.0
>
>         Attachments: HIVE-11575.patch
>
>
> Some of the recent commits related to HIVE-11304 is causing test failures in master. Following tests are failing
> {code}
> org.apache.hive.service.cli.operation.TestOperationLoggingAPIWithMr.testFetchResultsOfLogWithVerboseMode
> org.apache.hive.service.cli.operation.TestOperationLoggingAPIWithMr.testFetchResultsOfLogWithPerformanceMode
> org.apache.hive.service.cli.operation.TestOperationLoggingAPIWithTez.testFetchResultsOfLogWithVerboseMode
> org.apache.hive.service.cli.operation.TestOperationLoggingAPIWithTez.testFetchResultsOfLogWithPerformanceMode
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)