You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/08 06:10:56 UTC
[GitHub] [flink] zjuwangg opened a new pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
zjuwangg opened a new pull request #12028:
URL: https://github.com/apache/flink/pull/12028
## What is the purpose of the change
*When constant exists in group window key leads to error: Unsupported call:TUMBLE_END(TIMESTAMP(3) NOT NULL), detail exception can be found in [FLINK-17553](https://issues.apache.org/jira/browse/FLINK-17553#). This pr aims to solve this problem. *
## Brief change log
- *#e51960b add ProjectMergeRule after AggregateProjectPullUpConstantsRule.INSTANCE to solve the bug*
## Verifying this change
This change added tests and can be verified as follows:
- *Added test `testWindowGroupByOnConstant ` to verify the plan as expect*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: ( no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #12028:
URL: https://github.com/apache/flink/pull/12028#discussion_r430134412
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/WindowAggregateITCase.scala
##########
@@ -319,6 +319,49 @@ class WindowAggregateITCase(mode: StateBackendMode)
assertEquals(expected.sorted, sink.getRetractResults.sorted)
}
+ // used to verify compile works normally when constants exists in group window key (FLINK-17553)
+ @Test
+ def testWindowAggregateOnConstantValue(): Unit = {
+ val ddl1 =
+ """
+ |CREATE TABLE src (
+ | log_ts STRING,
+ | ts TIMESTAMP(3),
+ | a INT,
+ | b DOUBLE,
+ | rowtime AS CAST(log_ts AS TIMESTAMP(3)),
+ | WATERMARK FOR rowtime AS rowtime - INTERVAL '0.001' SECOND
+ |) WITH (
+ | 'connector' = 'COLLECTION',
+ | 'is-bounded' = 'false'
+ |)
+ """.stripMargin
+ val ddl2 =
+ """
+ |CREATE TABLE dst (
+ | ts TIMESTAMP(3),
+ | a BIGINT,
+ | b DOUBLE
+ |) WITH (
+ | 'connector.type' = 'filesystem',
+ | 'connector.path' = '/tmp/1',
+ | 'format.type' = 'csv'
+ |)
+ """.stripMargin
+ val query =
+ """
+ |INSERT INTO dst
+ |SELECT TUMBLE_END(rowtime, INTERVAL '0.003' SECOND), COUNT(ts), SUM(b)
+ |FROM src
+ | GROUP BY 'a', TUMBLE(rowtime, INTERVAL '0.003' SECOND)
+ """.stripMargin
+ tEnv.sqlUpdate(ddl1)
+ tEnv.sqlUpdate(ddl2)
+ tEnv.sqlUpdate(query)
+ tEnv.explain(true)
+ }
+
Review comment:
nit: redundant empty line
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/FlinkStreamRuleSets.scala
##########
@@ -109,6 +109,8 @@ object FlinkStreamRuleSets {
List(
//removes constant keys from an Agg
AggregateProjectPullUpConstantsRule.INSTANCE,
+ //fix: FLINK-17553 unsupported call error when constant exists in group window key
+ ProjectMergeRule.INSTANCE,
Review comment:
add the following sentence: this rule will merge the project generated by `AggregateProjectPullUpConstantsRule` and make sure window aggregate can be correctly rewritten by StreamLogicalWindowAggregateRule
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zjuwangg commented on pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
Posted by GitBox <gi...@apache.org>.
zjuwangg commented on pull request #12028:
URL: https://github.com/apache/flink/pull/12028#issuecomment-633774808
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #12028:
URL: https://github.com/apache/flink/pull/12028#discussion_r429726451
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/FlinkStreamRuleSets.scala
##########
@@ -109,6 +109,8 @@ object FlinkStreamRuleSets {
List(
//removes constant keys from an Agg
AggregateProjectPullUpConstantsRule.INSTANCE,
+ //fix: FLINK-17553
Review comment:
please give a more clear comment here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12028:
URL: https://github.com/apache/flink/pull/12028#issuecomment-625656822
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e51960bfa9933fc5515fde87896dbee100ef41f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=796",
"triggerID" : "e51960bfa9933fc5515fde87896dbee100ef41f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e51960bfa9933fc5515fde87896dbee100ef41f8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=796)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12028:
URL: https://github.com/apache/flink/pull/12028#issuecomment-625656822
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e51960bfa9933fc5515fde87896dbee100ef41f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=796",
"triggerID" : "e51960bfa9933fc5515fde87896dbee100ef41f8",
"triggerType" : "PUSH"
}, {
"hash" : "5ffb28916f4d997ff9294f2df87389c79a7d1951",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2114",
"triggerID" : "5ffb28916f4d997ff9294f2df87389c79a7d1951",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e51960bfa9933fc5515fde87896dbee100ef41f8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=796)
* 5ffb28916f4d997ff9294f2df87389c79a7d1951 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2114)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zjuwangg commented on a change in pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
Posted by GitBox <gi...@apache.org>.
zjuwangg commented on a change in pull request #12028:
URL: https://github.com/apache/flink/pull/12028#discussion_r435666321
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/WindowAggregateITCase.scala
##########
@@ -319,6 +319,48 @@ class WindowAggregateITCase(mode: StateBackendMode)
assertEquals(expected.sorted, sink.getRetractResults.sorted)
}
+ // used to verify compile works normally when constants exists in group window key (FLINK-17553)
+ @Test
+ def testWindowAggregateOnConstantValue(): Unit = {
+ val ddl1 =
+ """
+ |CREATE TABLE src (
+ | log_ts STRING,
+ | ts TIMESTAMP(3),
+ | a INT,
+ | b DOUBLE,
+ | rowtime AS CAST(log_ts AS TIMESTAMP(3)),
+ | WATERMARK FOR rowtime AS rowtime - INTERVAL '0.001' SECOND
+ |) WITH (
+ | 'connector' = 'COLLECTION',
+ | 'is-bounded' = 'false'
+ |)
+ """.stripMargin
+ val ddl2 =
+ """
+ |CREATE TABLE dst (
+ | ts TIMESTAMP(3),
+ | a BIGINT,
+ | b DOUBLE
+ |) WITH (
+ | 'connector.type' = 'filesystem',
+ | 'connector.path' = '/tmp/1',
+ | 'format.type' = 'csv'
+ |)
+ """.stripMargin
+ val query =
+ """
+ |INSERT INTO dst
+ |SELECT TUMBLE_END(rowtime, INTERVAL '0.003' SECOND), COUNT(ts), SUM(b)
+ |FROM src
+ | GROUP BY 'a', TUMBLE(rowtime, INTERVAL '0.003' SECOND)
+ """.stripMargin
+ tEnv.sqlUpdate(ddl1)
+ tEnv.sqlUpdate(ddl2)
+ tEnv.sqlUpdate(query)
+ tEnv.explain(true)
Review comment:
I got your meaning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12028:
URL: https://github.com/apache/flink/pull/12028#issuecomment-625652432
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e51960bfa9933fc5515fde87896dbee100ef41f8 (Fri May 08 06:13:35 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17553).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #12028:
URL: https://github.com/apache/flink/pull/12028
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12028:
URL: https://github.com/apache/flink/pull/12028#issuecomment-625656822
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e51960bfa9933fc5515fde87896dbee100ef41f8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e51960bfa9933fc5515fde87896dbee100ef41f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e51960bfa9933fc5515fde87896dbee100ef41f8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12028:
URL: https://github.com/apache/flink/pull/12028#issuecomment-625656822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12028:
URL: https://github.com/apache/flink/pull/12028#discussion_r433842050
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/WindowAggregateITCase.scala
##########
@@ -319,6 +319,48 @@ class WindowAggregateITCase(mode: StateBackendMode)
assertEquals(expected.sorted, sink.getRetractResults.sorted)
}
+ // used to verify compile works normally when constants exists in group window key (FLINK-17553)
+ @Test
+ def testWindowAggregateOnConstantValue(): Unit = {
+ val ddl1 =
+ """
+ |CREATE TABLE src (
+ | log_ts STRING,
+ | ts TIMESTAMP(3),
+ | a INT,
+ | b DOUBLE,
+ | rowtime AS CAST(log_ts AS TIMESTAMP(3)),
+ | WATERMARK FOR rowtime AS rowtime - INTERVAL '0.001' SECOND
+ |) WITH (
+ | 'connector' = 'COLLECTION',
+ | 'is-bounded' = 'false'
+ |)
+ """.stripMargin
+ val ddl2 =
+ """
+ |CREATE TABLE dst (
+ | ts TIMESTAMP(3),
+ | a BIGINT,
+ | b DOUBLE
+ |) WITH (
+ | 'connector.type' = 'filesystem',
+ | 'connector.path' = '/tmp/1',
+ | 'format.type' = 'csv'
+ |)
+ """.stripMargin
+ val query =
+ """
+ |INSERT INTO dst
+ |SELECT TUMBLE_END(rowtime, INTERVAL '0.003' SECOND), COUNT(ts), SUM(b)
+ |FROM src
+ | GROUP BY 'a', TUMBLE(rowtime, INTERVAL '0.003' SECOND)
+ """.stripMargin
+ tEnv.sqlUpdate(ddl1)
+ tEnv.sqlUpdate(ddl2)
+ tEnv.sqlUpdate(query)
+ tEnv.explain(true)
Review comment:
I think we should verify the result, otherwise, it doesn't need to be added to ITCase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12028:
URL: https://github.com/apache/flink/pull/12028#discussion_r434418377
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/WindowAggregateITCase.scala
##########
@@ -319,6 +319,48 @@ class WindowAggregateITCase(mode: StateBackendMode)
assertEquals(expected.sorted, sink.getRetractResults.sorted)
}
+ // used to verify compile works normally when constants exists in group window key (FLINK-17553)
+ @Test
+ def testWindowAggregateOnConstantValue(): Unit = {
+ val ddl1 =
+ """
+ |CREATE TABLE src (
+ | log_ts STRING,
+ | ts TIMESTAMP(3),
+ | a INT,
+ | b DOUBLE,
+ | rowtime AS CAST(log_ts AS TIMESTAMP(3)),
+ | WATERMARK FOR rowtime AS rowtime - INTERVAL '0.001' SECOND
+ |) WITH (
+ | 'connector' = 'COLLECTION',
+ | 'is-bounded' = 'false'
+ |)
+ """.stripMargin
+ val ddl2 =
+ """
+ |CREATE TABLE dst (
+ | ts TIMESTAMP(3),
+ | a BIGINT,
+ | b DOUBLE
+ |) WITH (
+ | 'connector.type' = 'filesystem',
+ | 'connector.path' = '/tmp/1',
+ | 'format.type' = 'csv'
+ |)
+ """.stripMargin
+ val query =
+ """
+ |INSERT INTO dst
+ |SELECT TUMBLE_END(rowtime, INTERVAL '0.003' SECOND), COUNT(ts), SUM(b)
+ |FROM src
+ | GROUP BY 'a', TUMBLE(rowtime, INTERVAL '0.003' SECOND)
+ """.stripMargin
+ tEnv.sqlUpdate(ddl1)
+ tEnv.sqlUpdate(ddl2)
+ tEnv.sqlUpdate(query)
+ tEnv.explain(true)
Review comment:
I would suggest to verify the result. Because you already added a plan test.
You can use the following to verify the result.
```scala
val sink = new TestingAppendSink
tEnv.sqlQuery(sql).toAppendStream[Row].addSink(sink)
env.execute()
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zjuwangg commented on a change in pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
Posted by GitBox <gi...@apache.org>.
zjuwangg commented on a change in pull request #12028:
URL: https://github.com/apache/flink/pull/12028#discussion_r434415210
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/WindowAggregateITCase.scala
##########
@@ -319,6 +319,48 @@ class WindowAggregateITCase(mode: StateBackendMode)
assertEquals(expected.sorted, sink.getRetractResults.sorted)
}
+ // used to verify compile works normally when constants exists in group window key (FLINK-17553)
+ @Test
+ def testWindowAggregateOnConstantValue(): Unit = {
+ val ddl1 =
+ """
+ |CREATE TABLE src (
+ | log_ts STRING,
+ | ts TIMESTAMP(3),
+ | a INT,
+ | b DOUBLE,
+ | rowtime AS CAST(log_ts AS TIMESTAMP(3)),
+ | WATERMARK FOR rowtime AS rowtime - INTERVAL '0.001' SECOND
+ |) WITH (
+ | 'connector' = 'COLLECTION',
+ | 'is-bounded' = 'false'
+ |)
+ """.stripMargin
+ val ddl2 =
+ """
+ |CREATE TABLE dst (
+ | ts TIMESTAMP(3),
+ | a BIGINT,
+ | b DOUBLE
+ |) WITH (
+ | 'connector.type' = 'filesystem',
+ | 'connector.path' = '/tmp/1',
+ | 'format.type' = 'csv'
+ |)
+ """.stripMargin
+ val query =
+ """
+ |INSERT INTO dst
+ |SELECT TUMBLE_END(rowtime, INTERVAL '0.003' SECOND), COUNT(ts), SUM(b)
+ |FROM src
+ | GROUP BY 'a', TUMBLE(rowtime, INTERVAL '0.003' SECOND)
+ """.stripMargin
+ tEnv.sqlUpdate(ddl1)
+ tEnv.sqlUpdate(ddl2)
+ tEnv.sqlUpdate(query)
+ tEnv.explain(true)
Review comment:
Agreed. Thanks for you suggestion.
Here I just want to verify that explain work normally instead of checking the result, but I don't find a proper test file to place it. Which file would you suggest me to place?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12028:
URL: https://github.com/apache/flink/pull/12028#issuecomment-625656822
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e51960bfa9933fc5515fde87896dbee100ef41f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=796",
"triggerID" : "e51960bfa9933fc5515fde87896dbee100ef41f8",
"triggerType" : "PUSH"
}, {
"hash" : "5ffb28916f4d997ff9294f2df87389c79a7d1951",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2114",
"triggerID" : "5ffb28916f4d997ff9294f2df87389c79a7d1951",
"triggerType" : "PUSH"
}, {
"hash" : "86e04bf10b62c7dd52655fc8a20340c3c0ba4d38",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2172",
"triggerID" : "86e04bf10b62c7dd52655fc8a20340c3c0ba4d38",
"triggerType" : "PUSH"
}, {
"hash" : "e8a455a8cc508ab9f8b9d28bfe4e4548709dd93a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2774",
"triggerID" : "e8a455a8cc508ab9f8b9d28bfe4e4548709dd93a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86e04bf10b62c7dd52655fc8a20340c3c0ba4d38 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2172)
* e8a455a8cc508ab9f8b9d28bfe4e4548709dd93a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2774)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12028:
URL: https://github.com/apache/flink/pull/12028#issuecomment-625656822
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e51960bfa9933fc5515fde87896dbee100ef41f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=796",
"triggerID" : "e51960bfa9933fc5515fde87896dbee100ef41f8",
"triggerType" : "PUSH"
}, {
"hash" : "5ffb28916f4d997ff9294f2df87389c79a7d1951",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5ffb28916f4d997ff9294f2df87389c79a7d1951",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e51960bfa9933fc5515fde87896dbee100ef41f8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=796)
* 5ffb28916f4d997ff9294f2df87389c79a7d1951 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12028:
URL: https://github.com/apache/flink/pull/12028#issuecomment-625656822
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e51960bfa9933fc5515fde87896dbee100ef41f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=796",
"triggerID" : "e51960bfa9933fc5515fde87896dbee100ef41f8",
"triggerType" : "PUSH"
}, {
"hash" : "5ffb28916f4d997ff9294f2df87389c79a7d1951",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2114",
"triggerID" : "5ffb28916f4d997ff9294f2df87389c79a7d1951",
"triggerType" : "PUSH"
}, {
"hash" : "86e04bf10b62c7dd52655fc8a20340c3c0ba4d38",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2172",
"triggerID" : "86e04bf10b62c7dd52655fc8a20340c3c0ba4d38",
"triggerType" : "PUSH"
}, {
"hash" : "e8a455a8cc508ab9f8b9d28bfe4e4548709dd93a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e8a455a8cc508ab9f8b9d28bfe4e4548709dd93a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86e04bf10b62c7dd52655fc8a20340c3c0ba4d38 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2172)
* e8a455a8cc508ab9f8b9d28bfe4e4548709dd93a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12028:
URL: https://github.com/apache/flink/pull/12028#issuecomment-639336551
Build is passed, Merging...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12028:
URL: https://github.com/apache/flink/pull/12028#issuecomment-625656822
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e51960bfa9933fc5515fde87896dbee100ef41f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=796",
"triggerID" : "e51960bfa9933fc5515fde87896dbee100ef41f8",
"triggerType" : "PUSH"
}, {
"hash" : "5ffb28916f4d997ff9294f2df87389c79a7d1951",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2114",
"triggerID" : "5ffb28916f4d997ff9294f2df87389c79a7d1951",
"triggerType" : "PUSH"
}, {
"hash" : "86e04bf10b62c7dd52655fc8a20340c3c0ba4d38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2172",
"triggerID" : "86e04bf10b62c7dd52655fc8a20340c3c0ba4d38",
"triggerType" : "PUSH"
}, {
"hash" : "e8a455a8cc508ab9f8b9d28bfe4e4548709dd93a",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2774",
"triggerID" : "e8a455a8cc508ab9f8b9d28bfe4e4548709dd93a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8a455a8cc508ab9f8b9d28bfe4e4548709dd93a Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2774)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12028:
URL: https://github.com/apache/flink/pull/12028#issuecomment-625656822
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e51960bfa9933fc5515fde87896dbee100ef41f8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=796",
"triggerID" : "e51960bfa9933fc5515fde87896dbee100ef41f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e51960bfa9933fc5515fde87896dbee100ef41f8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=796)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12028: [FLINK-17553][table]fix plan error when constant exists in group window key
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12028:
URL: https://github.com/apache/flink/pull/12028#issuecomment-625656822
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e51960bfa9933fc5515fde87896dbee100ef41f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=796",
"triggerID" : "e51960bfa9933fc5515fde87896dbee100ef41f8",
"triggerType" : "PUSH"
}, {
"hash" : "5ffb28916f4d997ff9294f2df87389c79a7d1951",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2114",
"triggerID" : "5ffb28916f4d997ff9294f2df87389c79a7d1951",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5ffb28916f4d997ff9294f2df87389c79a7d1951 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2114)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org