You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2019/01/08 11:58:00 UTC

[jira] [Resolved] (WICKET-6628) wicket-ioc needs to use ASM 7 and CGLIB 3.2.10 to be compatible with JDK11

     [ https://issues.apache.org/jira/browse/WICKET-6628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-6628.
-------------------------------------
       Resolution: Fixed
         Assignee: Martin Grigorov
    Fix Version/s: 8.3.0

> wicket-ioc needs to use ASM 7 and CGLIB 3.2.10 to be compatible with JDK11
> --------------------------------------------------------------------------
>
>                 Key: WICKET-6628
>                 URL: https://issues.apache.org/jira/browse/WICKET-6628
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-ioc
>    Affects Versions: 8.2.0
>            Reporter: Tobias Gierke
>            Assignee: Martin Grigorov
>            Priority: Major
>             Fix For: 8.3.0
>
>
> Trying to use Wicket 8.2. (more specificially, wicket-ioc 8.2 and the @SpringBean annotation) on OpenJDK 11 crashes when the application was also compiled to JDK11 bytecode (but works fine when compiling with --target 10 and running on OpenJDK 11).
> Java version:
> {code:java}
> openjdk version "11" 2018-09-25
> OpenJDK Runtime Environment 18.9 (build 11+28)
> OpenJDK 64-Bit Server VM 18.9 (build 11+28, mixed mode)
> {code}
>  
> Crash caused by outdated asm-utils version:
> {code:java}
>     java.lang.UnsupportedOperationException
>             at org.objectweb.asm.ClassVisitor.visitNestMemberExperimental(ClassVisitor.java:248)
>             at org.objectweb.asm.ClassReader.accept(ClassReader.java:651)
>             at org.objectweb.asm.ClassReader.accept(ClassReader.java:391)
>             at net.sf.cglib.proxy.BridgeMethodResolver.resolveAll(BridgeMethodResolver.java:70)
>             at net.sf.cglib.proxy.Enhancer.emitMethods(Enhancer.java:1132)
>             at net.sf.cglib.proxy.Enhancer.generateClass(Enhancer.java:630)
>             at net.sf.cglib.core.DefaultGeneratorStrategy.generate(DefaultGeneratorStrategy.java:25)
>             at net.sf.cglib.core.AbstractClassGenerator.generate(AbstractClassGenerator.java:329)
>             at net.sf.cglib.proxy.Enhancer.generate(Enhancer.java:492)
>             at net.sf.cglib.core.AbstractClassGenerator$ClassLoaderData$3.apply(AbstractClassGenerator.java:93)
>             at net.sf.cglib.core.AbstractClassGenerator$ClassLoaderData$3.apply(AbstractClassGenerator.java:91)
>             at net.sf.cglib.core.internal.LoadingCache$2.call(LoadingCache.java:54)
>             at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>             at net.sf.cglib.core.internal.LoadingCache.createEntry(LoadingCache.java:61)
>             at net.sf.cglib.core.internal.LoadingCache.get(LoadingCache.java:34)
>             at net.sf.cglib.core.AbstractClassGenerator$ClassLoaderData.get(AbstractClassGenerator.java:116)
>             at net.sf.cglib.core.AbstractClassGenerator.create(AbstractClassGenerator.java:291)
>             at net.sf.cglib.proxy.Enhancer.createHelper(Enhancer.java:480)
>             at net.sf.cglib.proxy.Enhancer.create(Enhancer.java:305)
>             at org.apache.wicket.proxy.LazyInitProxyFactory.createProxy(LazyInitProxyFactory.java:192)
> {code}
> After upgrading to asm-utils 7.0 we still got another crash caused by the outdated cglib dependency:
> {code:java}
> java.lang.UnsupportedOperationException: This feature requires ASM7
> at org.objectweb.asm.ClassVisitor.visitNestMember(ClassVisitor.java:236)
> at org.objectweb.asm.ClassReader.accept(ClassReader.java:651)
> at org.objectweb.asm.ClassReader.accept(ClassReader.java:391)
> at net.sf.cglib.proxy.BridgeMethodResolver.resolveAll(BridgeMethodResolver.java:70)
> at net.sf.cglib.proxy.Enhancer.emitMethods(Enhancer.java:1132)
> at net.sf.cglib.proxy.Enhancer.generateClass(Enhancer.java:630)
> at net.sf.cglib.core.DefaultGeneratorStrategy.generate(DefaultGeneratorStrategy.java:25)
> at net.sf.cglib.core.AbstractClassGenerator.generate(AbstractClassGenerator.java:329)
> at net.sf.cglib.proxy.Enhancer.generate(Enhancer.java:492)
> at net.sf.cglib.core.AbstractClassGenerator$ClassLoaderData$3.apply(AbstractClassGenerator.java:93)
> at net.sf.cglib.core.AbstractClassGenerator$ClassLoaderData$3.apply(AbstractClassGenerator.java:91)
> at net.sf.cglib.core.internal.LoadingCache$2.call(LoadingCache.java:54)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at net.sf.cglib.core.internal.LoadingCache.createEntry(LoadingCache.java:61)
> at net.sf.cglib.core.internal.LoadingCache.get(LoadingCache.java:34)
> at net.sf.cglib.core.AbstractClassGenerator$ClassLoaderData.get(AbstractClassGenerator.java:116)
> at net.sf.cglib.core.AbstractClassGenerator.create(AbstractClassGenerator.java:291)
> at net.sf.cglib.proxy.Enhancer.createHelper(Enhancer.java:480)
> at net.sf.cglib.proxy.Enhancer.create(Enhancer.java:305)
> at org.apache.wicket.proxy.LazyInitProxyFactory.createProxy(LazyInitProxyFactory.java:191){code}
> Adding the following to our pom.xml fixed the crashes:
> {code:java}
>     <dependency>
>       <groupId>org.ow2.asm</groupId>
>       <artifactId>asm-util</artifactId>
>       <version>7.0</version>
>     </dependency>
>     <dependency>
>       <groupId>cglib</groupId>
>       <artifactId>cglib</artifactId>
>       <version>3.2.10</version>
>     </dependency>
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)