You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/28 13:40:44 UTC

[GitHub] [camel-website] aashnajena opened a new pull request #282: Fix the broken header menu

aashnajena opened a new pull request #282: Fix the broken header menu
URL: https://github.com/apache/camel-website/pull/282
 
 
   As observed in PR #207 the submenus don't start from below the line. I think there was a PR about shifting the menu text to align with the other elements which caused this change. 
   - Instead of the margin, I have added padding. Padding left is 0 so that the drop-downs are aligned with the starting of the text
   - Added some padding to the down-arrow button, which seemed too close to the text.   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on issue #282: Fix the broken header menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #282: Fix the broken header menu
URL: https://github.com/apache/camel-website/pull/282#issuecomment-606247312
 
 
   The drop-down portion starts from below the grey line, so I can make the line beneath the main-menu item white, but it only spans the main-menu-text, not the entire width of the dropdown box.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #282: Fix the broken header menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #282: Fix the broken header menu
URL: https://github.com/apache/camel-website/pull/282#issuecomment-607229212
 
 
   This is how it looks currently:
   
   ![Screenshot_2020-04-01 Outreachy update - Apache Camel](https://user-images.githubusercontent.com/1306050/78138790-c708a300-7427-11ea-9697-d06e375299eb.png)
   
   For reference I think what we want is what we [had a month ago](https://web.archive.org/web/20200213140144/http://camel.apache.org/).
   
   ![Screenshot_2020-04-01 Home - Apache Camel](https://user-images.githubusercontent.com/1306050/78138889-ebfd1600-7427-11ea-9732-55118d2964a1.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena closed pull request #282: Fix the broken header menu

Posted by GitBox <gi...@apache.org>.
aashnajena closed pull request #282: Fix the broken header menu
URL: https://github.com/apache/camel-website/pull/282
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on issue #282: Fix the broken header menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #282: Fix the broken header menu
URL: https://github.com/apache/camel-website/pull/282#issuecomment-607252493
 
 
   I changed it!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on issue #282: Fix the broken header menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #282: Fix the broken header menu
URL: https://github.com/apache/camel-website/pull/282#issuecomment-607114217
 
 
   Rebased!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena edited a comment on issue #282: Fix the broken header menu

Posted by GitBox <gi...@apache.org>.
aashnajena edited a comment on issue #282: Fix the broken header menu
URL: https://github.com/apache/camel-website/pull/282#issuecomment-606247312
 
 
   The drop-down portion starts from below the grey line, so I can make the line beneath the main-menu item white, but it only spans the main-menu-text, not the entire width of the dropdown box. Please check now, thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on issue #282: Fix the broken header menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #282: Fix the broken header menu
URL: https://github.com/apache/camel-website/pull/282#issuecomment-607847419
 
 
   Resolved in PR #306.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services