You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/25 19:55:07 UTC
[GitHub] [arrow] westonpace opened a new pull request #9319: ARROW-11376: [C++] ThreadedTaskGroup failure with Thread Sanitizer enabled
westonpace opened a new pull request #9319:
URL: https://github.com/apache/arrow/pull/9319
In the test we were checking if the outer task set some varable before waiting on the task group. This was a potential data race and potential false positive. I fixed the initial condition to false to avoid false positives and then moved the check after the finish to avoid the data race. Also, while investigating, I noticed that the ok() method could be const but wasn't (at one point I thought this might be related to the issue) so I changed that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #9319: ARROW-11376: [C++] ThreadedTaskGroup failure with Thread Sanitizer enabled
Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #9319:
URL: https://github.com/apache/arrow/pull/9319#issuecomment-767120195
@pitrou Good catch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9319: ARROW-11376: [C++] ThreadedTaskGroup failure with Thread Sanitizer enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9319:
URL: https://github.com/apache/arrow/pull/9319#issuecomment-767073944
https://issues.apache.org/jira/browse/ARROW-11376
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #9319: ARROW-11376: [C++] ThreadedTaskGroup failure with Thread Sanitizer enabled
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #9319:
URL: https://github.com/apache/arrow/pull/9319
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #9319: ARROW-11376: [C++] ThreadedTaskGroup failure with Thread Sanitizer enabled
Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #9319:
URL: https://github.com/apache/arrow/pull/9319#issuecomment-767120195
@pitrou Good catch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9319: ARROW-11376: [C++] ThreadedTaskGroup failure with Thread Sanitizer enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9319:
URL: https://github.com/apache/arrow/pull/9319#issuecomment-767073944
https://issues.apache.org/jira/browse/ARROW-11376
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org