You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/02/26 12:45:47 UTC
[GitHub] [james-project] chibenwa opened a new pull request #898: JAMES-3715 Graceful shutdown for Netty servers
chibenwa opened a new pull request #898:
URL: https://github.com/apache/james-project/pull/898
Waits ongoing tasks being executed on Netty servers for a few seconds
before releasing underlying resources (like DB connections).
Especially on top of Cassandra components, this is a good first step
to minimize risks of shutdowns to cause inconsistencies.
The Netty4 migration enabled us to easily write such resilient
behaviour while it was not implemented for the previously existing
Netty 3 code. CF https://github.com/apache/james-project/pull/886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #898: JAMES-3715 Graceful shutdown for Netty servers
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #898:
URL: https://github.com/apache/james-project/pull/898#issuecomment-1053563091
This code need to be reworked: the graceful shutdown process takes ~2 seconds and we don't want to wait that long in tests.
Solution -> make it configurable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] glennosss commented on pull request #898: JAMES-3715 Graceful shutdown for Netty servers
Posted by GitBox <gi...@apache.org>.
glennosss commented on pull request #898:
URL: https://github.com/apache/james-project/pull/898#issuecomment-1074773999
I think you'll find `unbindNow()` is a cleaner way of doing this - see: https://github.com/glennosss/james-project/blob/netty4-combo/protocols/api/src/main/java/org/apache/james/protocols/api/ProtocolServer.java#L67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa edited a comment on pull request #898: JAMES-3715 Graceful shutdown for Netty servers
Posted by GitBox <gi...@apache.org>.
chibenwa edited a comment on pull request #898:
URL: https://github.com/apache/james-project/pull/898#issuecomment-1074774930
Alreanative PR welcomed ;-)
(Likely welcoming that: https://github.com/chibenwa/james-project/pull/31, please open it against the ASF repo)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #898: JAMES-3715 Graceful shutdown for Netty servers
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #898:
URL: https://github.com/apache/james-project/pull/898#issuecomment-1055588204
Reminder to self: I still need to turn off graceful shutdown in mailet integration tests...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa edited a comment on pull request #898: JAMES-3715 Graceful shutdown for Netty servers
Posted by GitBox <gi...@apache.org>.
chibenwa edited a comment on pull request #898:
URL: https://github.com/apache/james-project/pull/898#issuecomment-1074774930
Alreanative PR welcomed ;-)
(Likely welcoming that: https://github.com/chibenwa/james-project/pull/31)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #898: JAMES-3715 Graceful shutdown for Netty servers
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #898:
URL: https://github.com/apache/james-project/pull/898#issuecomment-1074774930
Alreanative PR welcomed ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org