[GitHub] [dubbo] aamingaa commented on a diff in pull request #12039: feat: triple exception self

["aamingaa (via GitHub)" <gi...@apache.org>]

aamingaa commented on code in PR #12039:
URL: https://github.com/apache/dubbo/pull/12039#discussion_r1162651716


##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/PbUnpack.java:
##########
@@ -35,4 +35,10 @@ public Object unpack(byte[] data) throws IOException {
         final ByteArrayInputStream bais = new ByteArrayInputStream(data);
         return SingleProtobufUtils.deserialize(bais, clz);
     }
+
+
+    public Object unpack(byte[] data, boolean isReturnTriException) throws IOException {

Review Comment:
   if remove it, the compiole with fail



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org