[GitHub] [trafficcontrol] zrhoffman commented on pull request #4765: Fix a couple TR NullPointerExceptions when no caches are available

[GitBox <gi...@apache.org>]

zrhoffman commented on pull request #4765:
URL: https://github.com/apache/trafficcontrol/pull/4765#issuecomment-644287927


   > I rebased to resolve merge conflicts, but I didn't actually have to change any of the code. Cache.java was basically just renamed to Node.java without having to change anything else.
   
   I think the intent is to still use Cache because
   * Although Cache was renamed to Node, a new class also named Cache was added in the Edge Traffic Routing PR, and it [extends Node](/apache/trafficcontrol/blob/aa03fd37f8/traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/edge/Cache.java#L30).
   * The usage of  Cache [doesn't change](/apache/trafficcontrol/blob/aa03fd37f8/traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/config/ConfigHandler.java#L356) in ConfigHandler after the Edge Traffic Routing PR was merged
   * Node [looks like](/apache/trafficcontrol/blob/aa03fd37f8/traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/config/ConfigHandler.java#L929) it is used for Edge Traffic Routing
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org