You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2026/02/12 22:27:55 UTC
[native-toolchain-CR] IMPALA-14717: Upgrade to CMake 3.31.11
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23975
Change subject: IMPALA-14717: Upgrade to CMake 3.31.11
......................................................................
IMPALA-14717: Upgrade to CMake 3.31.11
We recently found that the detection of AVX2 was broken due to
a bug in CMake 3.22.2. This bumps the version of CMake to a newer
version to help avoid those types of issues. Newer CMake also
added the file set functionality, which is useful for adding a
CMake build for google tcmalloc.
Change-Id: I16f0ce80053abd50b0399dc19b5b1028eb26926b
---
M init.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/75/23975/1
--
To view, visit http://gerrit.cloudera.org:8080/23975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16f0ce80053abd50b0399dc19b5b1028eb26926b
Gerrit-Change-Number: 23975
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[native-toolchain-CR] IMPALA-14717: Upgrade to CMake 3.31.11
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23975 )
Change subject: IMPALA-14717: Upgrade to CMake 3.31.11
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16f0ce80053abd50b0399dc19b5b1028eb26926b
Gerrit-Change-Number: 23975
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Feb 2026 22:31:41 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-14717: Upgrade to CMake 3.31.11
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23975 )
Change subject: IMPALA-14717: Upgrade to CMake 3.31.11
......................................................................
IMPALA-14717: Upgrade to CMake 3.31.11
We recently found that the detection of AVX2 was broken due to
a bug in CMake 3.22.2. This bumps the version of CMake to a newer
version to help avoid those types of issues. Newer CMake also
added the file set functionality, which is useful for adding a
CMake build for google tcmalloc.
Change-Id: I16f0ce80053abd50b0399dc19b5b1028eb26926b
Reviewed-on: http://gerrit.cloudera.org:8080/23975
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M init.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Joe McDonnell: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/23975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I16f0ce80053abd50b0399dc19b5b1028eb26926b
Gerrit-Change-Number: 23975
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-14717: Upgrade to CMake 3.31.11
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23975 )
Change subject: IMPALA-14717: Upgrade to CMake 3.31.11
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16f0ce80053abd50b0399dc19b5b1028eb26926b
Gerrit-Change-Number: 23975
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Feb 2026 03:36:49 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-14717: Upgrade to CMake 3.31.11
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23975 )
Change subject: IMPALA-14717: Upgrade to CMake 3.31.11
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/23975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16f0ce80053abd50b0399dc19b5b1028eb26926b
Gerrit-Change-Number: 23975
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Feb 2026 22:36:52 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-14717: Upgrade to CMake 3.31.11
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23975 )
Change subject: IMPALA-14717: Upgrade to CMake 3.31.11
......................................................................
Patch Set 3: Code-Review+2
Rebase, carrying +2
--
To view, visit http://gerrit.cloudera.org:8080/23975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16f0ce80053abd50b0399dc19b5b1028eb26926b
Gerrit-Change-Number: 23975
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Feb 2026 00:20:16 +0000
Gerrit-HasComments: No