[GitHub] flink pull request #6135: [FLINK-9546][core] Fix the checking of heartbeatTi...

[sihuazhou <gi...@git.apache.org>]

GitHub user sihuazhou opened a pull request:

    https://github.com/apache/flink/pull/6135

    [FLINK-9546][core] Fix the checking of heartbeatTimeoutIntervalMs in HeartbeatMonitor.

    ## What is the purpose of the change
    
    The heartbeatTimeoutIntervalMs of HeartbeatMonitor should be larger than 0, currently the arg check looks like
    
    ```java
    Preconditions.checkArgument(heartbeatTimeoutIntervalMs >= 0L, "The heartbeat timeout interval has to be larger than 0.");
    ```
    
    it should be
    
    ```java
    Preconditions.checkArgument(heartbeatTimeoutIntervalMs > 0L, "The heartbeat timeout interval has to be larger than 0.");
    ```
    
    ## Brief change log
    
      - *Fix the checking of heartbeatTimeoutIntervalMs in HeartbeatMonitor.*
    
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
    No
    
    ## Documentation
    
    No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sihuazhou/flink FLINK-9546

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6135.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6135
    
----
commit 5b7fab68afa434014308f2994a4ece89681c596d
Author: sihuazhou <su...@...>
Date:   2018-06-07T08:26:20Z

    fix the checking of heartbeatTimeoutIntervalMs in HeartbeatMonitor.

----


---

[GitHub] flink issue #6135: [FLINK-9546][core] Fix the checking of heartbeatTimeoutIn...

[sihuazhou <gi...@git.apache.org>]

Github user sihuazhou commented on the issue:

    https://github.com/apache/flink/pull/6135
  
    cc @tillrohrmann 


---