[GitHub] [hudi] xicm commented on pull request #8029: [HUDI-5832] add relocated prefix for hbase classes in hbase-site.xml

["xicm (via GitHub)" <gi...@apache.org>]

xicm commented on PR #8029:
URL: https://github.com/apache/hudi/pull/8029#issuecomment-1478859087

   
   
   
   > @danny0405 Thanks for review this. I give more context here.
   > 
   > I meet a problem about ClassNotFound exception `org.apache.hadoop.hbase.master.ClusterStatusPublisher$MulticastPublisher` during loading flink-hbase-connector and hudi-flink-bundle. Because we package `hbase-site.xml` in the bundle jar, and the value of `hbase.status.publisher.class` is `org.apache.hadoop.hbase.master.ClusterStatusPublisher$MulticastPublisher`, but it `hudi-flink-bundle`, the class location is `org/apache/hudi/org/apache/hadoop/hbase/master/ClusterStatusPublisher$MulticastPublisher`.
   > 
   > During open Hbase connection and write data to Hbase, the application will load the `hbase-site.xml` of `hudi-flink-bundle` jar, and latter try to initialise the class of `hbase.status.publisher.class` property, and then meet ClassNotFound problem.
   > 
   > So I'm thinking all configured classes properties should start with relocated prefix `org.apapche.hudi`.
   > 
   > @yihua could you please help to double check if it's reasonable?
   
   The shaded pattern can solve this problem, while for `hbase.status.listener.class` and `hbase.status.publisher.class` I am sure we can remove these two conf. Hbase can find these classes from classpath.
   Another question, what if some one just use hudi-common-*.jar?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org