[GitHub] jai1 commented on a change in pull request #763: Cpp producer sequence id changes

[gi...@git.apache.org]

jai1 commented on a change in pull request #763: Cpp producer sequence id changes
URL: https://github.com/apache/incubator-pulsar/pull/763#discussion_r139517681
 
 

 ##########
 File path: pulsar-client-cpp/include/pulsar/MessageBuilder.h
 ##########
 @@ -76,6 +76,24 @@ class MessageBuilder {
     MessageBuilder& setEventTimestamp(uint64_t eventTimestamp);
 
     /**
+     * Specify a custom sequence id for the message being published.
+     * <p>
+     * The sequence id can be used for deduplication purposes and it needs to follow these rules:
+     * <ol>
+     * <li><code>sequenceId >= 0</code>
 
 Review comment:
   Assertion for this - also why not use `uint64_t`
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services