You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Julius Davies (JIRA)" <ji...@apache.org> on 2010/03/27 05:30:28 UTC
[jira] Updated: (CODEC-99) Base64.encodeBase64String() shouldn't
chunk
[ https://issues.apache.org/jira/browse/CODEC-99?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julius Davies updated CODEC-99:
-------------------------------
Description:
Base64.encodeBase64String() shouldn't chunk.
Change this:
{code}
public static String encodeBase64String(byte[] binaryData) {
return StringUtils.newStringUtf8(encodeBase64(binaryData, true));
}
{code}
To this:
{code}
public static String encodeBase64String(byte[] binaryData) {
return StringUtils.newStringUtf8(encodeBase64(binaryData, false));
}
{code}
This will fix the following tests ggregory added a few minutes ago:
//assertEquals("Zg==", Base64.encodeBase64String(StringUtils.getBytesUtf8("f")));
//assertEquals("Zm8=", Base64.encodeBase64String(StringUtils.getBytesUtf8("fo")));
//assertEquals("Zm9v", Base64.encodeBase64String(StringUtils.getBytesUtf8("foo")));
//assertEquals("Zm9vYg==", Base64.encodeBase64String(StringUtils.getBytesUtf8("foob")));
//assertEquals("Zm9vYmE=", Base64.encodeBase64String(StringUtils.getBytesUtf8("fooba")));
//assertEquals("Zm9vYmFy", Base64.encodeBase64String(StringUtils.getBytesUtf8("foobar")));
was:
Base64.encodeBase64String() shouldn't chunk.
Change this:
{code}
public static String encodeBase64String(byte[] binaryData) {
return StringUtils.newStringUtf8(encodeBase64(binaryData, true));
}
{code}
To this:
{code}
public static String encodeBase64String(byte[] binaryData) {
return StringUtils.newStringUtf8(encodeBase64(binaryData, true));
}
{code}
This will fix the following tests ggregory added a few minutes ago:
//assertEquals("Zg==", Base64.encodeBase64String(StringUtils.getBytesUtf8("f")));
//assertEquals("Zm8=", Base64.encodeBase64String(StringUtils.getBytesUtf8("fo")));
//assertEquals("Zm9v", Base64.encodeBase64String(StringUtils.getBytesUtf8("foo")));
//assertEquals("Zm9vYg==", Base64.encodeBase64String(StringUtils.getBytesUtf8("foob")));
//assertEquals("Zm9vYmE=", Base64.encodeBase64String(StringUtils.getBytesUtf8("fooba")));
//assertEquals("Zm9vYmFy", Base64.encodeBase64String(StringUtils.getBytesUtf8("foobar")));
> Base64.encodeBase64String() shouldn't chunk
> -------------------------------------------
>
> Key: CODEC-99
> URL: https://issues.apache.org/jira/browse/CODEC-99
> Project: Commons Codec
> Issue Type: Bug
> Affects Versions: 1.4
> Reporter: Julius Davies
>
> Base64.encodeBase64String() shouldn't chunk.
> Change this:
> {code}
> public static String encodeBase64String(byte[] binaryData) {
> return StringUtils.newStringUtf8(encodeBase64(binaryData, true));
> }
> {code}
> To this:
> {code}
> public static String encodeBase64String(byte[] binaryData) {
> return StringUtils.newStringUtf8(encodeBase64(binaryData, false));
> }
> {code}
> This will fix the following tests ggregory added a few minutes ago:
> //assertEquals("Zg==", Base64.encodeBase64String(StringUtils.getBytesUtf8("f")));
> //assertEquals("Zm8=", Base64.encodeBase64String(StringUtils.getBytesUtf8("fo")));
> //assertEquals("Zm9v", Base64.encodeBase64String(StringUtils.getBytesUtf8("foo")));
> //assertEquals("Zm9vYg==", Base64.encodeBase64String(StringUtils.getBytesUtf8("foob")));
> //assertEquals("Zm9vYmE=", Base64.encodeBase64String(StringUtils.getBytesUtf8("fooba")));
> //assertEquals("Zm9vYmFy", Base64.encodeBase64String(StringUtils.getBytesUtf8("foobar")));
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.