You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@airavata.apache.org by GitBox <gi...@apache.org> on 2019/10/29 13:40:57 UTC
[GitHub] [airavata-custos] isururanawaka commented on a change in pull
request #11: User Profile SDK
isururanawaka commented on a change in pull request #11: User Profile SDK
URL: https://github.com/apache/airavata-custos/pull/11#discussion_r340069177
##########
File path: clients/python/airavata_custos/admin/iam_admin_client.py
##########
@@ -16,24 +16,22 @@
#
import logging
-import configparser
from airavata_custos import utils
-from airavata_custos.settings import ProfileSettings
+from airavata_custos.configuration import Configuration
logger = logging.getLogger(__name__)
class IAMAdminClient(object):
- def __init__(self, configuration_file_location):
+ def __init__(self, configuration: Configuration):
"""
constructor for IAMAdminClient class
- :param configuration_file_location: takes the location of the ini file containing server configuration
+ :param configuration: object of class Configuration which has hosts/ports for custos services
"""
- self.profile_settings = ProfileSettings()
- self._load_settings(configuration_file_location)
- self.iamadmin_client_pool = utils.initialize_iamadmin_client_pool(self.profile_settings.PROFILE_SERVICE_HOST,
- self.profile_settings.PROFILE_SERVICE_PORT)
+
+ self.iamadmin_client_pool = utils.initialize_iamadmin_client_pool(configuration.PROFILE_SERVICE_HOST,
+ configuration.PROFILE_SERVICE_PORT)
Review comment:
Why IAMAdminClient has its own pool ? or is it external connection pool ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services