[jira] [Commented] (MYFACES-3439) [perf] ApplicationImpl: use cached info about ResourceDependecies for behaviors, converters and validators

["Leonardo Uribe (Commented) (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182944#comment-13182944 ] 

Leonardo Uribe commented on MYFACES-3439:
-----------------------------------------

We can't apply the patch proposed because there are some subtle details between _handleAttachedResourceDependency and _handleResourceDependency that makes not possible to use one variant. It is better copy the code from

private void _handleResourceDependencyAnnotations(FacesContext context, Class<?> inspectedClass,
                                                      UIComponent component, boolean isProduction)

to 

private void _handleAttachedResourceDependencyAnnotations(FacesContext context, Object inspected)

and adjust the code to call the right code.

Thanks for the patch proposed and for notice this improvement.
                
> [perf] ApplicationImpl: use cached info about ResourceDependecies for behaviors, converters and validators
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-3439
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3439
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 2.0.12-SNAPSHOT, 2.1.6-SNAPSHOT
>         Environment: myfaces core trunk
>            Reporter: Martin Kočí
>            Assignee: Martin Kočí
>            Priority: Minor
>         Attachments: MYFACES-3439-1.patch, MYFACES-3439.patch
>
>
> Solution is simple: ApplicationImpl has already method _handleResourceDependencyAnnotations for renderers and components. This method caches infos about ResourceDependecies annotations.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira