You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2015/12/29 07:28:32 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-542 ] Paragraph running,...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/580
ZEPPELIN-542 ] Paragraph running, the page move is not possible.
### What is this PR for?
Paragraph running, the page move is not possible.
If this Paragraph is running, you can not move to another page, such as the Interpreter Page.
Please check the Animated GIF.
### What type of PR is it?
Bug Fix
### Todos
- [x] NEW_NOTE / CLONE_NOTE generated events on front-web
- [x] NEW / CLONE NOTE Event Response separation backend-server.
### Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-542
### How should this be tested?
Step 1. Write more than 10 Paragraph as follows
``` scala
Thread.sleep(2000);
```
Step 2. Run All Paragraph (or Run Notebook)
Step 3. Go to another page, except for the Notebook.
### Screenshots (if appropriate)
#### before (bug)
#### after (fixed)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/incubator-zeppelin bug_fix/RefreshParagraph
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/580.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #580
----
commit f589e7b3f394eeed2e34c8b41c125f06170dc923
Author: CloverHearts <es...@gmail.com>
Date: 2015-12-29T06:09:36Z
bug-fixed-force-redirect
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-542 ] Paragraph running,...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/580#issuecomment-167740478
Can't reproduce
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-542 ] Paragraph running,...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/580#issuecomment-168357372
@corneadoug
OK.
I'll check it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-542 ] Paragraph running,...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/580#issuecomment-167752481
@prabhjyotsingh
Thank, you for Feedback.
I know the code.
However, the function of the code is when the Clone note or New Note event occurs,
(e.g. In the Navigation create note)
Any position to move to a newly created note.
And, i have determined that the problem of server side code, because the root cause of this problem.
And the NOTE NEW CLONE NOTE events, separated from the server side, which I think are right to send.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-542 ] Paragraph running,...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/580#issuecomment-169203430
@cloverhearts Tested again, no problems.
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-542 ] Paragraph running,...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/580#issuecomment-167744285
I understand there are multiple ways to solve this problem, but the reason this is happening is
zeppelin-web/src/components/noteName-create/notename.controller.js
@@ -37,6 +37,7 @@ angular.module('zeppelinWebApp').controller('NotenameCtrl', function($scope, $ro
$scope.$on('setNoteContent', function(event, note) {
//a hack, to make it run only after notebook creation
//it should not run i.e in case of linking to the paragraph
+ //TODO fix this
if (note && $location.path().indexOf(note.id) < 0) {
$location.path('notebook/' + note.id);
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-542 ] Paragraph running,...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/580
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-542 ] Paragraph running,...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/580#issuecomment-167741618
@corneadoug
'Thread.sleep (2000);' Generating a more than 5, and after running the entire notebook, page, go to the interpreter.
Run the notebook is running, please wait until terminated.
* Go to the interpreter before, the notebook must state that at least one of the remaining PENDING.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-542 ] Paragraph running,...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/580#issuecomment-167742533
@corneadoug Sorry. Can you check again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-542 ] Paragraph running,...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/580#issuecomment-167949727
@corneadoug
The sympathetic to your ideas. thank you.
I have completed the modifications.
Sorry to bother but once again the review Would it be possible?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-542 ] Paragraph running,...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/580#issuecomment-167915875
A few changes that would simplify the code:
* Reduce the event type to `NEW_NOTE` only instead of having both `NEW_NOTE` and `CLONE_NOTE`
(Since copy and create is making a new note anyway)
* Make the location change directly inside `websocketEvents.factory.js` and remove `$scope.$on('createNoteContent` from `notename.controller.js`
it would looke like this:
```
if (op === 'NOTE') {
$rootScope.$broadcast('setNoteContent', data.note);
} else if (op === 'NEW_NOTE') {
$location.path('notebook/' + data.note.id);
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-542 ] Paragraph running,...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/580#issuecomment-167944166
1. I tried it, it works great, no need for controller to handle it. (in which case it should be app.controller to do it)
2. Yes it is server-side code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-542 ] Paragraph running,...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/580#issuecomment-168355882
@cloverhearts When I create a note from Home page, I'm not getting back a 'NEW_NOTE' message, so redirection is not working, its just showing an empty page
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-542 ] Paragraph running,...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/580#issuecomment-167936450
@corneadoug
I have a question. I will try to fix the node as your opinion.
However, there is two thing that troubled part.
1. The proposed codes are who you appear to be implemented in websocketEvents.factory.js.
But I think the websocketEvents.factory.js only raise the event. I think such actions will redirect websocketEvents.factory.js not happen, not later be processed in a dependency problem Controller.js to handle it.
2. NEW-NOTE, and CLONE_NOTE, suggesting it unifies the event as NEW_NOTE Is modify server-side code?
I respect the opinion of the @corneadoug.
Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-542 ] Paragraph running,...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/580#issuecomment-167919706
@corneadoug
gooood!!! Thanyou!!!
I'll fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-542 ] Paragraph running,...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/580#issuecomment-169208290
@corneadoug
Thank you! have a nice day.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-542 ] Paragraph running,...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/580#issuecomment-168962725
@corneadoug
Sorry, @corneadoug.
I can not reproduce your problem.
I 'NEW NOTE' message has been received without any problems.
Sorry, Can you check again?
I will ask to add this test to the people around me.
Happy New year
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-542 ] Paragraph running,...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/580#issuecomment-167754694
Sure, otherwise tested, looks good, and worked as expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---