You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2019/02/07 22:47:34 UTC
[Impala-ASF-CR] IMPALA-8173: Fix KeyError in run-workload.py
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12397
Change subject: IMPALA-8173: Fix KeyError in run-workload.py
......................................................................
IMPALA-8173: Fix KeyError in run-workload.py
A recent change (IMPALA-7694) causes run-workload.py to fail with a
KeyError due to trying to construct an ImpalaBeeswaxResult without a
query id.
This patch fixes that issue and two related issues:
- This problem was not caught by automated testing even though we run
run-workload.py in run-all-tests.sh because of an issue where
queries that fail to produce results are silently ignored.
- Fixes an issue where queries that fail to produce results would
confusingly produce the error:
'NoneType' object has no attribute 'time_taken'
Testing:
- Ran run-workload.py locally and demonstrated that it works now.
- Ran run-all-tests.sh locally and demonstrated that it fails now when
the KeyError issue isn't fixed.
Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
---
M tests/performance/query_exec_functions.py
M tests/performance/scheduler.py
2 files changed, 14 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/12397/1
--
To view, visit http://gerrit.cloudera.org:8080/12397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
Gerrit-Change-Number: 12397
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-8173: Fix KeyError in run-workload.py
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12397 )
Change subject: IMPALA-8173: Fix KeyError in run-workload.py
......................................................................
Patch Set 2: Code-Review+2
Thanks for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/12397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
Gerrit-Change-Number: 12397
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Fri, 08 Feb 2019 09:26:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8173: Fix KeyError in run-workload.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12397 )
Change subject: IMPALA-8173: Fix KeyError in run-workload.py
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3757/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
Gerrit-Change-Number: 12397
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Mon, 11 Feb 2019 19:47:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8173: Fix KeyError in run-workload.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12397 )
Change subject: IMPALA-8173: Fix KeyError in run-workload.py
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12397/1/tests/performance/scheduler.py
File tests/performance/scheduler.py:
http://gerrit.cloudera.org:8080/#/c/12397/1/tests/performance/scheduler.py@123
PS1, Line 123: +
flake8: E226 missing whitespace around arithmetic operator
http://gerrit.cloudera.org:8080/#/c/12397/1/tests/performance/scheduler.py@123
PS1, Line 123: ,
flake8: E501 line too long (91 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/12397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
Gerrit-Change-Number: 12397
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Feb 2019 22:48:25 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8173: Fix KeyError in run-workload.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12397 )
Change subject: IMPALA-8173: Fix KeyError in run-workload.py
......................................................................
IMPALA-8173: Fix KeyError in run-workload.py
A recent change (IMPALA-7694) causes run-workload.py to fail with a
KeyError due to trying to construct an ImpalaBeeswaxResult without a
query id.
This patch fixes that issue and two related issues:
- This problem was not caught by automated testing even though we run
run-workload.py in run-all-tests.sh because of an issue where
queries that fail to produce results are silently ignored.
- Fixes an issue where queries that fail to produce results would
confusingly produce the error:
'NoneType' object has no attribute 'time_taken'
Testing:
- Ran run-workload.py locally and demonstrated that it works now.
- Ran run-all-tests.sh locally and demonstrated that it fails now when
the KeyError issue isn't fixed.
Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
Reviewed-on: http://gerrit.cloudera.org:8080/12397
Reviewed-by: Thomas Marshall <th...@cmu.edu>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/performance/query_exec_functions.py
M tests/performance/scheduler.py
2 files changed, 16 insertions(+), 10 deletions(-)
Approvals:
Thomas Marshall: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
Gerrit-Change-Number: 12397
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-8173: Fix KeyError in run-workload.py
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12397 )
Change subject: IMPALA-8173: Fix KeyError in run-workload.py
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12397/1/tests/performance/scheduler.py
File tests/performance/scheduler.py:
http://gerrit.cloudera.org:8080/#/c/12397/1/tests/performance/scheduler.py@123
PS1, Line 123:
> flake8: E501 line too long (91 > 90 characters)
Done
http://gerrit.cloudera.org:8080/#/c/12397/1/tests/performance/scheduler.py@123
PS1, Line 123:
> flake8: E226 missing whitespace around arithmetic operator
Done
--
To view, visit http://gerrit.cloudera.org:8080/12397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
Gerrit-Change-Number: 12397
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 07 Feb 2019 22:51:36 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8173: Fix KeyError in run-workload.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12397 )
Change subject: IMPALA-8173: Fix KeyError in run-workload.py
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2030/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
Gerrit-Change-Number: 12397
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 07 Feb 2019 23:32:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8173: Fix KeyError in run-workload.py
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12397 )
Change subject: IMPALA-8173: Fix KeyError in run-workload.py
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
Gerrit-Change-Number: 12397
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 07 Feb 2019 23:00:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8173: Fix KeyError in run-workload.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12397 )
Change subject: IMPALA-8173: Fix KeyError in run-workload.py
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
Gerrit-Change-Number: 12397
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Tue, 12 Feb 2019 00:03:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8173: Fix KeyError in run-workload.py
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, David Knupp, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12397
to look at the new patch set (#3).
Change subject: IMPALA-8173: Fix KeyError in run-workload.py
......................................................................
IMPALA-8173: Fix KeyError in run-workload.py
A recent change (IMPALA-7694) causes run-workload.py to fail with a
KeyError due to trying to construct an ImpalaBeeswaxResult without a
query id.
This patch fixes that issue and two related issues:
- This problem was not caught by automated testing even though we run
run-workload.py in run-all-tests.sh because of an issue where
queries that fail to produce results are silently ignored.
- Fixes an issue where queries that fail to produce results would
confusingly produce the error:
'NoneType' object has no attribute 'time_taken'
Testing:
- Ran run-workload.py locally and demonstrated that it works now.
- Ran run-all-tests.sh locally and demonstrated that it fails now when
the KeyError issue isn't fixed.
Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
---
M tests/performance/query_exec_functions.py
M tests/performance/scheduler.py
2 files changed, 16 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/12397/3
--
To view, visit http://gerrit.cloudera.org:8080/12397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
Gerrit-Change-Number: 12397
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-8173: Fix KeyError in run-workload.py
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12397
to look at the new patch set (#2).
Change subject: IMPALA-8173: Fix KeyError in run-workload.py
......................................................................
IMPALA-8173: Fix KeyError in run-workload.py
A recent change (IMPALA-7694) causes run-workload.py to fail with a
KeyError due to trying to construct an ImpalaBeeswaxResult without a
query id.
This patch fixes that issue and two related issues:
- This problem was not caught by automated testing even though we run
run-workload.py in run-all-tests.sh because of an issue where
queries that fail to produce results are silently ignored.
- Fixes an issue where queries that fail to produce results would
confusingly produce the error:
'NoneType' object has no attribute 'time_taken'
Testing:
- Ran run-workload.py locally and demonstrated that it works now.
- Ran run-all-tests.sh locally and demonstrated that it fails now when
the KeyError issue isn't fixed.
Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
---
M tests/performance/query_exec_functions.py
M tests/performance/scheduler.py
2 files changed, 14 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/12397/2
--
To view, visit http://gerrit.cloudera.org:8080/12397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
Gerrit-Change-Number: 12397
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8173: Fix KeyError in run-workload.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12397 )
Change subject: IMPALA-8173: Fix KeyError in run-workload.py
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2028/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
Gerrit-Change-Number: 12397
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 07 Feb 2019 23:15:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8173: Fix KeyError in run-workload.py
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12397 )
Change subject: IMPALA-8173: Fix KeyError in run-workload.py
......................................................................
Patch Set 3: Code-Review+2
carrying forward
--
To view, visit http://gerrit.cloudera.org:8080/12397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
Gerrit-Change-Number: 12397
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Mon, 11 Feb 2019 21:19:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8173: Fix KeyError in run-workload.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12397 )
Change subject: IMPALA-8173: Fix KeyError in run-workload.py
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2071/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
Gerrit-Change-Number: 12397
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Mon, 11 Feb 2019 20:19:10 +0000
Gerrit-HasComments: No