You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "fallintoplace (via GitHub)" <gi...@apache.org> on 2026/07/23 00:59:17 UTC

[PR] fix(table): validate snapshot references [iceberg-go]

fallintoplace opened a new pull request, #1512:
URL: https://github.com/apache/iceberg-go/pull/1512

   ## Summary
   
   - require `snapshot-id` and `type` when decoding snapshot references
   - reject non-positive retention values
   - reject branch-only retention settings on tags during decoding and metadata updates
   
   ## Why
   
   The Java `SnapshotRef` builder and parser enforce these invariants, but Go only checked the reference type while decoding. Programmatic metadata updates also allowed tag references with `min-snapshots-to-keep` or `max-snapshot-age-ms`, producing metadata Java rejects.
   
   ## Testing
   
   - `go test ./...`
   - `go test -race ./table`
   - `go vet ./...`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix(table): validate snapshot references [iceberg-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #1512:
URL: https://github.com/apache/iceberg-go/pull/1512


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org