[GitHub] [shardingsphere-on-cloud] mlycore commented on issue #264: ComputeNode status is not precisely sync with Pod status

["mlycore (via GitHub)" <gi...@apache.org>]

mlycore commented on issue #264:
URL: https://github.com/apache/shardingsphere-on-cloud/issues/264#issuecomment-1471224897

   In this function `getReadyInstances()`, we just align with the ready status true. And it will only be updated in next reconcliation.
   
   https://github.com/apache/shardingsphere-on-cloud/blob/c500401936ea8faadbc37b9eb959d91b01984a36/shardingsphere-operator/pkg/controllers/compute_node_controller.go#L321-L337
   
   We define `readyInstances` to imply how many proxy instances are ready to accept connections. So it should be real-time. And ReadinessProbe are executed periodically, new conditions will be updated every time it executes. 
   
   Perhaps we need to check the `kubectl get pod` and see if we need to update our `getReadyInstances` logic. @yikuaibro 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org