You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by qmlmoon <gi...@git.apache.org> on 2015/01/09 12:47:50 UTC
[GitHub] flink pull request: [FLINK-1229][FLINK-1206] Synchronize webclient...
GitHub user qmlmoon opened a pull request:
https://github.com/apache/flink/pull/291
[FLINK-1229][FLINK-1206] Synchronize webclient arguments with command line and add default parallelism option
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/qmlmoon/incubator-flink webclient-syn
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/291.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #291
----
commit f782daf843c608052aa9adba45c75aa70b506291
Author: mingliang <qm...@gmail.com>
Date: 2015-01-07T18:49:32Z
[FLINK-1229][FLINK-1206] Synchronize webclient arguments with command line and add default parallelism.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1229][FLINK-1206] Synchronize webclient...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/291#issuecomment-70415920
Looks good to be merged, in my opinion!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1229][FLINK-1206] Synchronize webclient...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/291#discussion_r22725368
--- Diff: flink-clients/src/main/java/org/apache/flink/client/web/JobSubmissionServlet.java ---
@@ -146,10 +146,22 @@ protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws Se
}
String assemblerClass = null;
- if (params.size() >= 2 && params.get(0).equals("assembler")) {
- assemblerClass = params.get(1);
- params.remove(0);
- params.remove(0);
+ int pos = 0;
+ int parallelism = -1;
+ while(pos < params.size()) {
--- End diff --
This should probably be `pos < params.size() - 1`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1229][FLINK-1206] Synchronize webclient...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/291
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1229][FLINK-1206] Synchronize webclient...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/291#issuecomment-69358452
Good idea. Two comments inline, but otherwise looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1229][FLINK-1206] Synchronize webclient...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/291#discussion_r22725429
--- Diff: flink-clients/src/main/java/org/apache/flink/client/web/JobSubmissionServlet.java ---
@@ -146,10 +146,22 @@ protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws Se
}
String assemblerClass = null;
- if (params.size() >= 2 && params.get(0).equals("assembler")) {
- assemblerClass = params.get(1);
- params.remove(0);
- params.remove(0);
+ int pos = 0;
+ int parallelism = -1;
+ while(pos < params.size()) {
+ if (params.get(pos).equals("-c")) {
+ assemblerClass = params.get(pos + 1);
+ params.remove(pos);
+ params.remove(pos);
+ }
+ else if (params.get(pos).equals("-p")) {
+ parallelism = Integer.parseInt(params.get(pos + 1));
+ params.remove(pos);
+ params.remove(pos);
+ }
+ else {
+ pos++;
--- End diff --
If you change this to `break`, it will only accept these flags before the user program arguments (not mixed with them), which makes sense and reflects the way the command line handles it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---