[jira] [Commented] (FLINK-4394) RMQSource: The QueueName is not accessible to subclasses

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420704#comment-15420704 ] 

ASF GitHub Bot commented on FLINK-4394:
---------------------------------------

GitHub user theomega opened a pull request:

    https://github.com/apache/flink/pull/2373

    [FLINK-4394] RMQSource: QueueName accessible for subclasses

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    The queueName is needed if the subclasses override `setupQueue`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/theomega/flink patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2373
    
----
commit 04d6bf46e8d8684494522cd0c92ad462922d0af4
Author: Dominik <do...@dbruhn.de>
Date:   2016-08-15T07:41:57Z

    RMQSource: QueueName accessible for subclasses
    
    The queueName is needed if the subclasses override `setupQueue`.

----


> RMQSource: The QueueName is not accessible to subclasses
> --------------------------------------------------------
>
>                 Key: FLINK-4394
>                 URL: https://issues.apache.org/jira/browse/FLINK-4394
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming Connectors
>    Affects Versions: 1.1.1
>            Reporter: Dominik Bruhn
>
> In version 1.1.0 we made the RMQSource extensible so that subclasses can configure how they want their queue for RabbitMQ/AMQP create. The subclasses can override 
> {code}
> 	protected void setupQueue() throws IOException {
> 		channel.queueDeclare(queueName, true, false, false, null);
> 	}
> {code}
> The problem is, that the queueName property is private. So when override the setupQueue parameter, you don't know what actual queueName was provided. A simple change of the queueName property to protected fixes this.
> PR will follow



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)