[GitHub] [fluo-muchos] keith-turner commented on a change in pull request #306: Implement terminate and wipe actions for Azure clusters

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #306: Implement terminate and wipe actions for Azure clusters
URL: https://github.com/apache/fluo-muchos/pull/306#discussion_r366043111
 
 

 ##########
 File path: lib/muchos/existing.py
 ##########
 @@ -241,6 +241,10 @@ def perform(self, action):
             elif action == 'cancel_shutdown':
                 print("Cancelling automatic shutdown of {0} cluster".format(self.config.cluster_name))
             self.execute_playbook(action + ".yml")
+            # In case of Azure, also check and if necessary wipe the storage accounts
+            # It is necessary to do this after the common kill and wipe to ensure that processes are all killed prior to this
+            if  action == 'wipe' and self.config.get("general", "cluster_type") == 'azure':
 
 Review comment:
   Would be nice to put azure specific code in azure.py if possible.  One possible way to do this is to create a `wipe()` method in existing.py that does nothing, override it in azure.py, and call `wipe()` here.  Alternatively, would it make sense for wipe.yml to call azure-wipe-adlsg2.yml in ansible instead of doing it from Pytyhon?  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services