[jira] [Commented] (HBASE-14693) Add client-side metrics for received pushback signals

["Andrew Purtell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988768#comment-14988768 ] 

Andrew Purtell commented on HBASE-14693:
----------------------------------------

Mostly lgtm.

Fix this typo. Should be incrNormalRunners. 
{code}
@@ -242,6 +333,21 @@ public class MetricsConnection {
     metaCacheMisses.inc();
   }
 
+  /** Increment the number of normal runner counts. */
+  public void incrNormaRunners() {
+    this.runnerStats.incrNormalRunners();
+  }
{code}

I can fix this on commit if there's nothing else.

> Add client-side metrics for received pushback signals
> -----------------------------------------------------
>
>                 Key: HBASE-14693
>                 URL: https://issues.apache.org/jira/browse/HBASE-14693
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Andrew Purtell
>            Assignee: Heng Chen
>             Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.16
>
>         Attachments: HBASE-14693.patch, HBASE-14693_v1.patch, HBASE-14693_v2.patch, HBASE-14693_v3.patch
>
>
> HBASE-12911 added client side metrics. HBASE-5162 added a mechanism for sending advisory backpressure signals to clients when the server is heavily loaded, and HBASE-12702 and subtasks backported this to all active branches. Add client-side metrics for received pushback signal. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)