You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/09/23 08:32:45 UTC

[GitHub] [incubator-druid] jihoonson opened a new pull request #8573: Stateful auto compaction

jihoonson opened a new pull request #8573: Stateful auto compaction
URL: https://github.com/apache/incubator-druid/pull/8573
 
 
   Fixes #8489.
   
   ### Description
   
   In addition to #8489, `targetCompactionSizeBytes` is dropped for the compaction task and auto compaction. `targetCompactionSizeBytes` was added for easy configuration, but it could be a misleading that optimizing segments should be done in terms of the size rather than number of rows. Dropping `targetCompactionSizeBytes` also makes things simpler such that all tasks can share the same partitionsSpec since `targetCompactionSizeBytes` makes sense only for compaction task.
   `maxRowsPerSegment` now is a mandatory configuration for auto compaction. For compaction task, any partitionsSpec can be used.
   
   Also fixed a bug that auto compaction couldn't compact an interval if there is only one segment. Note that compaction can split a segment into smaller ones.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added documentation for new or modified features or behaviors.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [x] added unit tests or modified existing tests to cover new code paths.
   - [x] been tested in a test Druid cluster.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org