You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by sa...@apache.org on 2016/03/17 00:29:00 UTC
incubator-geode git commit: fixed review remarks
Repository: incubator-geode
Updated Branches:
refs/heads/feature/GEODE-1017 35c933ddd -> e9d9e512b
fixed review remarks
Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/e9d9e512
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/e9d9e512
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/e9d9e512
Branch: refs/heads/feature/GEODE-1017
Commit: e9d9e512be5068e5d7a29bc22a15eb9f2149568e
Parents: 35c933d
Author: Sai Boorlagadda <sb...@pivotal.io>
Authored: Wed Mar 16 16:28:44 2016 -0700
Committer: Sai Boorlagadda <sb...@pivotal.io>
Committed: Wed Mar 16 16:28:44 2016 -0700
----------------------------------------------------------------------
.../com/gemstone/gemfire/internal/offheap/OffHeapStorage.java | 2 +-
.../internal/offheap/MemoryAllocatorFillPatternJUnitTest.java | 4 ++--
.../com/gemstone/gemfire/internal/offheap/OffHeapRegionBase.java | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/e9d9e512/geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStorage.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStorage.java b/geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStorage.java
index 1a38f3f..0976259 100755
--- a/geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStorage.java
+++ b/geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStorage.java
@@ -69,7 +69,7 @@ public class OffHeapStorage implements OffHeapMemoryStats {
final String usedMemoryDesc = "The amount of off-heap memory, in bytes, that is being used to store data.";
final String defragmentationDesc = "The total number of times off-heap memory has been defragmented.";
- final String defragmentationTimeDesc = "The total time spent deframenting off-heap memory.";
+ final String defragmentationTimeDesc = "The total time spent defragmenting off-heap memory.";
final String fragmentationDesc = "The percentage of off-heap free memory that is fragmented. Updated every time a defragmentation is performed.";
final String fragmentsDesc = "The number of fragments of free off-heap memory. Updated every time a defragmentation is done.";
final String freeMemoryDesc = "The amount of off-heap memory, in bytes, that is not being used.";
http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/e9d9e512/geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/MemoryAllocatorFillPatternJUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/MemoryAllocatorFillPatternJUnitTest.java b/geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/MemoryAllocatorFillPatternJUnitTest.java
index f19863a..7036187 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/MemoryAllocatorFillPatternJUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/MemoryAllocatorFillPatternJUnitTest.java
@@ -51,7 +51,7 @@ public class MemoryAllocatorFillPatternJUnitTest {
private static final int DEFRAGMENTATION_CHUNK_SIZE = (SLAB_SIZE / DEFRAGMENTATION_CHUNKS) - 1024;
/** This should force defragmentation when allocated. */
- private static final int FORCE_DEFRAGMENATATION_CHUNK_SIZE = DEFRAGMENTATION_CHUNK_SIZE * 2;
+ private static final int FORCE_DEFRAGMENTATION_CHUNK_SIZE = DEFRAGMENTATION_CHUNK_SIZE * 2;
/** Our test victim. */
private MemoryAllocatorImpl allocator = null;
@@ -173,7 +173,7 @@ public class MemoryAllocatorFillPatternJUnitTest {
* our initial chunks. This should force a defragmentation causing our
* memory to look like [ ][ ].
*/
- OffHeapStoredObject slightlyLargerChunk = (OffHeapStoredObject) this.allocator.allocate(FORCE_DEFRAGMENATATION_CHUNK_SIZE);
+ OffHeapStoredObject slightlyLargerChunk = (OffHeapStoredObject) this.allocator.allocate(FORCE_DEFRAGMENTATION_CHUNK_SIZE);
/*
* Make sure the defragmented memory has the fill validation.
http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/e9d9e512/geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionBase.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionBase.java b/geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionBase.java
index bf71352..02673a2 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionBase.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionBase.java
@@ -99,7 +99,7 @@ public abstract class OffHeapRegionBase {
assertEquals(offHeapSize, ma.getFreeMemory());
assertEquals(0, ma.getUsedMemory());
// do an allocation larger than the slab size
- // TODO: currently the defragment will product slabs bigger than the max slab size
+ // TODO: currently the defragment will produce slabs bigger than the max slab size
// (see the todo comment on defragment() in FreeListManager).
// So we request 20m here since that it the total size.
try {