You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/17 09:55:47 UTC

[GitHub] [airflow] kazanzhy opened a new issue #19638: Resolve parameter name for SqlSensor, BaseSqlOperator, Connection

kazanzhy opened a new issue #19638:
URL: https://github.com/apache/airflow/issues/19638


   ### Apache Airflow version
   
   2.2.2 (latest released)
   
   ### Operating System
   
   Ubuntu
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Deployment
   
   Virtualenv installation
   
   ### Deployment details
   
   _No response_
   
   ### What happened
   
   There are different names for the same keyword argument:
   `BaseSqlOperator(hook_params)` - by PR https://github.com/apache/airflow/pull/18718
   `Connection.get_hook(hook_kwargs)` - by PR https://github.com/apache/airflow/pull/18718
   `SqlSensor(hook_params)` - by PR https://github.com/apache/airflow/pull/18431
   
   Plan:
   - Rename `hook_kwargs ` to `hook_params` in Connection.get_hook (https://github.com/apache/airflow/blob/6df69df421dfc6f1485f637aa74fc3dab0e2b9a4/airflow/models/connection.py#L288)
   - Rename usage in BaseSqlOperator (https://github.com/apache/airflow/blob/6df69df421dfc6f1485f637aa74fc3dab0e2b9a4/airflow/operators/sql.py#L68)
   - Rename usage in SqlSensor (https://github.com/kazanzhy/airflow/blob/459a652e831785f362fd3443c46b53161f8bfc72/airflow/sensors/sql.py#L87)
   
   ### What you expected to happen
   
   _No response_
   
   ### How to reproduce
   
   _No response_
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #19638: Resolve parameter name for SqlSensor, BaseSqlOperator, Connection

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #19638:
URL: https://github.com/apache/airflow/issues/19638#issuecomment-971415866


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk closed issue #19638: Resolve parameter name for SqlSensor, BaseSqlOperator, Connection

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #19638:
URL: https://github.com/apache/airflow/issues/19638


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org