You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/28 00:15:01 UTC
[GitHub] [beam] pabloem opened a new pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
pabloem opened a new pull request #12713:
URL: https://github.com/apache/beam/pull/12713
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace
--- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12713:
URL: https://github.com/apache/beam/pull/12713#issuecomment-682268077
# [Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=h1) Report
> Merging [#12713](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **decrease** coverage by `4.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12713 +/- ##
==========================================
- Coverage 40.22% 35.95% -4.27%
==========================================
Files 454 722 +268
Lines 53669 86442 +32773
==========================================
+ Hits 21587 31084 +9497
- Misses 32082 55358 +23276
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [setup.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [...python/apache\_beam/runners/direct/direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZGlyZWN0X3J1bm5lci5weQ==) | | |
| [...s/python/apache\_beam/io/aws/clients/s3/messages.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXdzL2NsaWVudHMvczMvbWVzc2FnZXMucHk=) | | |
| [...ache\_beam/examples/cookbook/bigquery\_side\_input.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29va2Jvb2svYmlncXVlcnlfc2lkZV9pbnB1dC5weQ==) | | |
| [sdks/python/apache\_beam/runners/direct/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvX19pbml0X18ucHk=) | | |
| [...eam/runners/interactive/options/capture\_control.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfY29udHJvbC5weQ==) | | |
| [...python/apache\_beam/examples/streaming\_wordcount.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc3RyZWFtaW5nX3dvcmRjb3VudC5weQ==) | | |
| [sdks/python/apache\_beam/typehints/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL19faW5pdF9fLnB5) | | |
| [...ython/apache\_beam/examples/kafkataxi/kafka\_taxi.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMva2Fma2F0YXhpL2thZmthX3RheGkucHk=) | | |
| [...ers/interactive/display/pipeline\_graph\_renderer.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9kaXNwbGF5L3BpcGVsaW5lX2dyYXBoX3JlbmRlcmVyLnB5) | | |
| ... and [1158 more](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=footer). Last update [2872e37...568c25d](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12713:
URL: https://github.com/apache/beam/pull/12713#issuecomment-682268077
# [Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=h1) Report
> Merging [#12713](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **decrease** coverage by `4.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12713 +/- ##
==========================================
- Coverage 40.22% 35.95% -4.27%
==========================================
Files 454 722 +268
Lines 53669 86442 +32773
==========================================
+ Hits 21587 31084 +9497
- Misses 32082 55358 +23276
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [setup.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [...ples/snippets/transforms/aggregation/groupbykey.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9ncm91cGJ5a2V5LnB5) | | |
| [sdks/python/apache\_beam/dataframe/doctests.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2RvY3Rlc3RzLnB5) | | |
| [sdks/python/apache\_beam/options/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9fX2luaXRfXy5weQ==) | | |
| [sdks/python/apache\_beam/coders/avro\_record.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2F2cm9fcmVjb3JkLnB5) | | |
| [...n/apache\_beam/runners/direct/evaluation\_context.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXZhbHVhdGlvbl9jb250ZXh0LnB5) | | |
| [...\_beam/testing/benchmarks/nexmark/queries/query1.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvcXVlcmllcy9xdWVyeTEucHk=) | | |
| [...s/python/apache\_beam/utils/thread\_pool\_executor.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdGhyZWFkX3Bvb2xfZXhlY3V0b3IucHk=) | | |
| [sdks/python/apache\_beam/io/filebasedsource.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWJhc2Vkc291cmNlLnB5) | | |
| [sdks/python/apache\_beam/io/fileio.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWlvLnB5) | | |
| ... and [1158 more](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=footer). Last update [2872e37...b4221b4](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on a change in pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #12713:
URL: https://github.com/apache/beam/pull/12713#discussion_r482218727
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -118,13 +118,15 @@ class DataflowRunner(PipelineRunner):
from apache_beam.runners.dataflow.ptransform_overrides import CreatePTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import JrhReadPTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import ReadPTransformOverride
+ from apache_beam.runners.dataflow.ptransform_overrides import ReadBigQuerySourcePTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import NativeReadPTransformOverride
# These overrides should be applied before the proto representation of the
# graph is created.
_PTRANSFORM_OVERRIDES = [
CombineValuesPTransformOverride(),
NativeReadPTransformOverride(),
+ ReadBigQuerySourcePTransformOverride(),
Review comment:
alright, I'll do that instead then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #12713:
URL: https://github.com/apache/beam/pull/12713#issuecomment-684032855
Run Python 3.8 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on a change in pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #12713:
URL: https://github.com/apache/beam/pull/12713#discussion_r482224353
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -118,13 +118,15 @@ class DataflowRunner(PipelineRunner):
from apache_beam.runners.dataflow.ptransform_overrides import CreatePTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import JrhReadPTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import ReadPTransformOverride
+ from apache_beam.runners.dataflow.ptransform_overrides import ReadBigQuerySourcePTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import NativeReadPTransformOverride
# These overrides should be applied before the proto representation of the
# graph is created.
_PTRANSFORM_OVERRIDES = [
CombineValuesPTransformOverride(),
NativeReadPTransformOverride(),
+ ReadBigQuerySourcePTransformOverride(),
Review comment:
.. an issue with this, though, is that BigQuerySource is wrapped by a Read transform. So we'd have `Read(BigQuerySource(...))` - and so we would have then a `Read(ReadFromBigQuery(...))`, which would not work. We can also return the `_CustomBigQuerySource`, but it would be missing the clean up after the export jobs. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on a change in pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #12713:
URL: https://github.com/apache/beam/pull/12713#discussion_r485654737
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -118,13 +118,15 @@ class DataflowRunner(PipelineRunner):
from apache_beam.runners.dataflow.ptransform_overrides import CreatePTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import JrhReadPTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import ReadPTransformOverride
+ from apache_beam.runners.dataflow.ptransform_overrides import ReadBigQuerySourcePTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import NativeReadPTransformOverride
# These overrides should be applied before the proto representation of the
# graph is created.
_PTRANSFORM_OVERRIDES = [
CombineValuesPTransformOverride(),
NativeReadPTransformOverride(),
+ ReadBigQuerySourcePTransformOverride(),
Review comment:
Working on https://github.com/apache/beam/pull/12782 to do the correct override
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #12713:
URL: https://github.com/apache/beam/pull/12713#issuecomment-682254106
Run Python PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on a change in pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on a change in pull request #12713:
URL: https://github.com/apache/beam/pull/12713#discussion_r483282665
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -118,13 +118,15 @@ class DataflowRunner(PipelineRunner):
from apache_beam.runners.dataflow.ptransform_overrides import CreatePTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import JrhReadPTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import ReadPTransformOverride
+ from apache_beam.runners.dataflow.ptransform_overrides import ReadBigQuerySourcePTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import NativeReadPTransformOverride
# These overrides should be applied before the proto representation of the
# graph is created.
_PTRANSFORM_OVERRIDES = [
CombineValuesPTransformOverride(),
NativeReadPTransformOverride(),
+ ReadBigQuerySourcePTransformOverride(),
Review comment:
Seems like we are creating the proto pipeline after applying the overrides: https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py#L482
So overrides will be reflected in the proto ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on a change in pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
robertwb commented on a change in pull request #12713:
URL: https://github.com/apache/beam/pull/12713#discussion_r481446948
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner_test.py
##########
@@ -259,18 +260,6 @@ def test_bigquery_read_streaming_fail(self):
PipelineOptions(self.default_properties)) as p:
_ = p | beam.io.Read(beam.io.BigQuerySource('some.table'))
- def test_biqquery_read_fn_api_fail(self):
Review comment:
Wouldn't we still want an error most fo the time? (E.g. this is still broken on OSS runners.)
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -118,13 +118,15 @@ class DataflowRunner(PipelineRunner):
from apache_beam.runners.dataflow.ptransform_overrides import CreatePTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import JrhReadPTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import ReadPTransformOverride
+ from apache_beam.runners.dataflow.ptransform_overrides import ReadBigQuerySourcePTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import NativeReadPTransformOverride
# These overrides should be applied before the proto representation of the
# graph is created.
_PTRANSFORM_OVERRIDES = [
CombineValuesPTransformOverride(),
NativeReadPTransformOverride(),
+ ReadBigQuerySourcePTransformOverride(),
Review comment:
The problem with putting this as an override here is that it would be called *after* the beam protos are created.
Instead of implementing this as a (Dataflow-only) override, it'd be better to change `beam.io.bigquery.BigQuerySource` into a function that returns a `ReadFromBigquery` transform.
We could either remove the native `BigQuerySource` altogether, or add a (temporary) keyword argument `use_native_source` to our new `BigQuerySource` function to branch on as an escape hatch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12713:
URL: https://github.com/apache/beam/pull/12713#issuecomment-682268077
# [Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=h1) Report
> Merging [#12713](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/39e74c471e33eb00b591e196b29f1f4fb9d30ab0?el=desc) will **increase** coverage by `1.63%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12713 +/- ##
==========================================
+ Coverage 34.32% 35.95% +1.63%
==========================================
Files 695 722 +27
Lines 82234 86442 +4208
Branches 9295 0 -9295
==========================================
+ Hits 28225 31084 +2859
- Misses 53586 55358 +1772
+ Partials 423 0 -423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [io/gcp/tests/bigquery\_matcher\_test.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-aW8vZ2NwL3Rlc3RzL2JpZ3F1ZXJ5X21hdGNoZXJfdGVzdC5weQ==) | | |
| [...ive/messaging/interactive\_environment\_inspector.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9tZXNzYWdpbmcvaW50ZXJhY3RpdmVfZW52aXJvbm1lbnRfaW5zcGVjdG9yLnB5) | | |
| [runners/dataflow/dataflow\_metrics\_test.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19tZXRyaWNzX3Rlc3QucHk=) | | |
| [runners/interactive/interactive\_beam.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9iZWFtLnB5) | | |
| [tools/runtime\_type\_check\_microbenchmark.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-dG9vbHMvcnVudGltZV90eXBlX2NoZWNrX21pY3JvYmVuY2htYXJrLnB5) | | |
| [runners/interactive/display/pipeline\_graph\_test.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9kaXNwbGF5L3BpcGVsaW5lX2dyYXBoX3Rlc3QucHk=) | | |
| [examples/snippets/snippets\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvc25pcHBldHMvc25pcHBldHNfdGVzdF9weTMucHk=) | | |
| [examples/complete/game/game\_stats\_it\_test.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvY29tcGxldGUvZ2FtZS9nYW1lX3N0YXRzX2l0X3Rlc3QucHk=) | | |
| [testing/pipeline\_verifiers.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-dGVzdGluZy9waXBlbGluZV92ZXJpZmllcnMucHk=) | | |
| [runners/dataflow/internal/apiclient.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9hcGljbGllbnQucHk=) | | |
| ... and [1407 more](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=footer). Last update [59ee4fb...8777680](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #12713:
URL: https://github.com/apache/beam/pull/12713#issuecomment-683115024
Run Python 3.8 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12713:
URL: https://github.com/apache/beam/pull/12713#issuecomment-682268077
# [Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=h1) Report
> Merging [#12713](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/39e74c471e33eb00b591e196b29f1f4fb9d30ab0?el=desc) will **increase** coverage by `1.63%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12713 +/- ##
==========================================
+ Coverage 34.32% 35.95% +1.63%
==========================================
Files 695 722 +27
Lines 82234 86442 +4208
Branches 9295 0 -9295
==========================================
+ Hits 28225 31084 +2859
- Misses 53586 55358 +1772
+ Partials 423 0 -423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [testing/test\_pipeline.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-dGVzdGluZy90ZXN0X3BpcGVsaW5lLnB5) | | |
| [.../direct/consumer\_tracking\_pipeline\_visitor\_test.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-cnVubmVycy9kaXJlY3QvY29uc3VtZXJfdHJhY2tpbmdfcGlwZWxpbmVfdmlzaXRvcl90ZXN0LnB5) | | |
| [coders/coders.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-Y29kZXJzL2NvZGVycy5weQ==) | | |
| [io/gcp/bigquery\_avro\_tools\_test.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-aW8vZ2NwL2JpZ3F1ZXJ5X2F2cm9fdG9vbHNfdGVzdC5weQ==) | | |
| [...internal/clients/dataflow/message\_matchers\_test.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9jbGllbnRzL2RhdGFmbG93L21lc3NhZ2VfbWF0Y2hlcnNfdGVzdC5weQ==) | | |
| [examples/cookbook/multiple\_output\_pardo.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvY29va2Jvb2svbXVsdGlwbGVfb3V0cHV0X3BhcmRvLnB5) | | |
| [coders/observable.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-Y29kZXJzL29ic2VydmFibGUucHk=) | | |
| [io/aws/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-aW8vYXdzL19faW5pdF9fLnB5) | | |
| [...ples/snippets/transforms/elementwise/pardo\_test.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9lbGVtZW50d2lzZS9wYXJkb190ZXN0LnB5) | | |
| [pvalue.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-cHZhbHVlLnB5) | | |
| ... and [1407 more](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=footer). Last update [59ee4fb...5249b50](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12713:
URL: https://github.com/apache/beam/pull/12713#issuecomment-682268077
# [Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=h1) Report
> Merging [#12713](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/39e74c471e33eb00b591e196b29f1f4fb9d30ab0?el=desc) will **increase** coverage by `1.63%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12713 +/- ##
==========================================
+ Coverage 34.32% 35.95% +1.63%
==========================================
Files 695 722 +27
Lines 82234 86442 +4208
Branches 9295 0 -9295
==========================================
+ Hits 28225 31084 +2859
- Misses 53586 55358 +1772
+ Partials 423 0 -423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [runners/runner\_test.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-cnVubmVycy9ydW5uZXJfdGVzdC5weQ==) | | |
| [examples/cookbook/coders\_test.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvY29va2Jvb2svY29kZXJzX3Rlc3QucHk=) | | |
| [transforms/window.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy93aW5kb3cucHk=) | | |
| [testing/load\_tests/load\_test.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-dGVzdGluZy9sb2FkX3Rlc3RzL2xvYWRfdGVzdC5weQ==) | | |
| [internal/pickler.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcGlja2xlci5weQ==) | | |
| [runners/portability/stager\_test.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-cnVubmVycy9wb3J0YWJpbGl0eS9zdGFnZXJfdGVzdC5weQ==) | | |
| [...amples/snippets/transforms/aggregation/distinct.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9kaXN0aW5jdC5weQ==) | | |
| [runners/interactive/pipeline\_fragment\_test.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9mcmFnbWVudF90ZXN0LnB5) | | |
| [...mples/snippets/transforms/elementwise/partition.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9lbGVtZW50d2lzZS9wYXJ0aXRpb24ucHk=) | | |
| [runners/worker/worker\_status\_test.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1c190ZXN0LnB5) | | |
| ... and [1407 more](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=footer). Last update [59ee4fb...5249b50](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12713:
URL: https://github.com/apache/beam/pull/12713#issuecomment-682268077
# [Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=h1) Report
> Merging [#12713](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `4.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12713 +/- ##
==========================================
- Coverage 40.22% 35.95% -4.27%
==========================================
Files 454 722 +268
Lines 53669 86442 +32773
==========================================
+ Hits 21587 31084 +9497
- Misses 32082 55358 +23276
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [setup.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [...flow/internal/clients/dataflow/message\_matchers.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9jbGllbnRzL2RhdGFmbG93L21lc3NhZ2VfbWF0Y2hlcnMucHk=) | | |
| [sdks/python/apache\_beam/examples/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvX19pbml0X18ucHk=) | | |
| [...ython/apache\_beam/typehints/decorators\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL2RlY29yYXRvcnNfdGVzdF9weTMucHk=) | | |
| [...n/apache\_beam/runners/direct/test\_direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9kaXJlY3RfcnVubmVyLnB5) | | |
| [...am/portability/api/external\_transforms\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2V4dGVybmFsX3RyYW5zZm9ybXNfcGIyX2dycGMucHk=) | | |
| [...ache\_beam/testing/benchmarks/chicago\_taxi/setup.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL2NoaWNhZ29fdGF4aS9zZXR1cC5weQ==) | | |
| [.../python/apache\_beam/io/gcp/tests/pubsub\_matcher.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL3B1YnN1Yl9tYXRjaGVyLnB5) | | |
| [...beam/testing/benchmarks/chicago\_taxi/preprocess.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL2NoaWNhZ29fdGF4aS9wcmVwcm9jZXNzLnB5) | | |
| [...s/python/apache\_beam/ml/gcp/videointelligenceml.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWwvZ2NwL3ZpZGVvaW50ZWxsaWdlbmNlbWwucHk=) | | |
| ... and [1158 more](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=footer). Last update [2872e37...7da4404](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on a change in pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #12713:
URL: https://github.com/apache/beam/pull/12713#discussion_r482421240
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -118,13 +118,15 @@ class DataflowRunner(PipelineRunner):
from apache_beam.runners.dataflow.ptransform_overrides import CreatePTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import JrhReadPTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import ReadPTransformOverride
+ from apache_beam.runners.dataflow.ptransform_overrides import ReadBigQuerySourcePTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import NativeReadPTransformOverride
# These overrides should be applied before the proto representation of the
# graph is created.
_PTRANSFORM_OVERRIDES = [
CombineValuesPTransformOverride(),
NativeReadPTransformOverride(),
+ ReadBigQuerySourcePTransformOverride(),
Review comment:
Furthermore, BQSource is only useful on Dataflow (it does have a local workaround implementation for DirectRunner, which we can also override if it makes sense..)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #12713:
URL: https://github.com/apache/beam/pull/12713#issuecomment-682272167
Run Python 3.8 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #12713:
URL: https://github.com/apache/beam/pull/12713#issuecomment-682256224
Run Python 3.6 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #12713:
URL: https://github.com/apache/beam/pull/12713#issuecomment-685016861
Run Python 3.8 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #12713:
URL: https://github.com/apache/beam/pull/12713#issuecomment-682268077
# [Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=h1) Report
> Merging [#12713](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/39e74c471e33eb00b591e196b29f1f4fb9d30ab0?el=desc) will **increase** coverage by `1.63%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12713 +/- ##
==========================================
+ Coverage 34.32% 35.95% +1.63%
==========================================
Files 695 722 +27
Lines 82234 86442 +4208
Branches 9295 0 -9295
==========================================
+ Hits 28225 31084 +2859
- Misses 53586 55358 +1772
+ Partials 423 0 -423
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [io/gcp/gcsio\_overrides.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-aW8vZ2NwL2djc2lvX292ZXJyaWRlcy5weQ==) | | |
| [...rs/interactive/display/pcoll\_visualization\_test.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9kaXNwbGF5L3Bjb2xsX3Zpc3VhbGl6YXRpb25fdGVzdC5weQ==) | | |
| [transforms/util\_test.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy91dGlsX3Rlc3QucHk=) | | |
| [examples/wordcount\_debugging.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvd29yZGNvdW50X2RlYnVnZ2luZy5weQ==) | | |
| [typehints/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL19faW5pdF9fLnB5) | | |
| [examples/snippets/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvc25pcHBldHMvX19pbml0X18ucHk=) | | |
| [metrics/monitoring\_infos\_test.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-bWV0cmljcy9tb25pdG9yaW5nX2luZm9zX3Rlc3QucHk=) | | |
| [coders/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-Y29kZXJzL19faW5pdF9fLnB5) | | |
| [portability/api/metrics\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-cG9ydGFiaWxpdHkvYXBpL21ldHJpY3NfcGIyX3VybnMucHk=) | | |
| [typehints/typed\_pipeline\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVkX3BpcGVsaW5lX3Rlc3RfcHkzLnB5) | | |
| ... and [1407 more](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=footer). Last update [59ee4fb...5249b50](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on a change in pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
robertwb commented on a change in pull request #12713:
URL: https://github.com/apache/beam/pull/12713#discussion_r483316482
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -118,13 +118,15 @@ class DataflowRunner(PipelineRunner):
from apache_beam.runners.dataflow.ptransform_overrides import CreatePTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import JrhReadPTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import ReadPTransformOverride
+ from apache_beam.runners.dataflow.ptransform_overrides import ReadBigQuerySourcePTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import NativeReadPTransformOverride
# These overrides should be applied before the proto representation of the
# graph is created.
_PTRANSFORM_OVERRIDES = [
CombineValuesPTransformOverride(),
NativeReadPTransformOverride(),
+ ReadBigQuerySourcePTransformOverride(),
Review comment:
You're right, the proto is created later. I still think it would be cleaner to construct the right pipeline from the start than mutate it later with overrides. Let's patch up Read to accept PTransforms just as we do for Write https://github.com/apache/beam/blob/release-2.18.0/sdks/python/apache_beam/io/iobase.py#L951 (I thought this was already done.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem closed pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
pabloem closed pull request #12713:
URL: https://github.com/apache/beam/pull/12713
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12713:
URL: https://github.com/apache/beam/pull/12713#issuecomment-682268077
# [Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=h1) Report
> Merging [#12713](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **decrease** coverage by `4.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12713 +/- ##
==========================================
- Coverage 40.22% 35.95% -4.27%
==========================================
Files 454 722 +268
Lines 53669 86442 +32773
==========================================
+ Hits 21587 31084 +9497
- Misses 32082 55358 +23276
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [setup.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [...ow/dataflow\_exercise\_streaming\_metrics\_pipeline.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19leGVyY2lzZV9zdHJlYW1pbmdfbWV0cmljc19waXBlbGluZS5weQ==) | | |
| [...ache\_beam/runners/portability/local\_job\_service.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZS5weQ==) | | |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | | |
| [sdks/python/apache\_beam/dataframe/transforms.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL3RyYW5zZm9ybXMucHk=) | | |
| [.../python/apache\_beam/tools/coders\_microbenchmark.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdG9vbHMvY29kZXJzX21pY3JvYmVuY2htYXJrLnB5) | | |
| [.../apache\_beam/tools/fn\_api\_runner\_microbenchmark.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdG9vbHMvZm5fYXBpX3J1bm5lcl9taWNyb2JlbmNobWFyay5weQ==) | | |
| [sdks/python/apache\_beam/runners/runner.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9ydW5uZXIucHk=) | | |
| [.../runners/interactive/testing/test\_cache\_manager.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL3Rlc3RfY2FjaGVfbWFuYWdlci5weQ==) | | |
| [...s/python/apache\_beam/io/gcp/bigquery\_avro\_tools.py](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X2F2cm9fdG9vbHMucHk=) | | |
| ... and [1158 more](https://codecov.io/gh/apache/beam/pull/12713/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=footer). Last update [2872e37...23fa8bc](https://codecov.io/gh/apache/beam/pull/12713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #12713:
URL: https://github.com/apache/beam/pull/12713#issuecomment-683115508
Run PythonLint PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #12713:
URL: https://github.com/apache/beam/pull/12713#issuecomment-685120609
Run Python 3.8 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org