You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/13 13:57:55 UTC
[GitHub] [spark] Comonut opened a new pull request #29424: [MINOR] Fixed approx_count_distinct rsd param description
Comonut opened a new pull request #29424:
URL: https://github.com/apache/spark/pull/29424
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
In the docs concerning the approx_count_distinct I have changed the description of the rsd parameter from **_maximum estimation error allowed_** to _**maximum relative standard deviation allowed**_
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Maximum estimation error allowed can be misleading. You can set the target relative standard deviation, which affects the estimation error, but on given runs the estimation error can still be above the rsd parameter.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
This PR should make it easier for users reading the docs to understand that the rsd parameter in approx_count_distinct doesn't cap the estimation error, but just sets the target deviation instead,
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
No tests, as no code changes were made.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29424: [SQL][MINOR] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-673497518
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29424: [MINOR][SQL] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-674064635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29424: [SQL][MINOR] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-673856142
Looks fine. Can you address the style nits @Comonut?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29424: [MINOR][SQL] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-673953626
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29424: [SQL][MINOR] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-673756454
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29424: [MINOR][SQL] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-674067965
Thanks! Merged to master/branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29424: [SQL][MINOR] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-673756078
**[Test build #127426 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127426/testReport)** for PR 29424 at commit [`1a405a8`](https://github.com/apache/spark/commit/1a405a871c0377feff0f865d71ec306cf4b138c9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29424: [MINOR][SQL] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-673953226
**[Test build #127448 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127448/testReport)** for PR 29424 at commit [`aab1e1a`](https://github.com/apache/spark/commit/aab1e1aea902619c87902cb9654527673a265bab).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29424: [MINOR] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-673497518
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29424: [MINOR] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-673755517
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29424: [SQL][MINOR] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-673756454
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29424: [SQL][MINOR] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-673756569
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29424: [MINOR] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-673496947
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Comonut commented on pull request #29424: [MINOR][SQL] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
Comonut commented on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-673952022
Thanks! Style issues should be fine now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #29424: [MINOR][SQL] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #29424:
URL: https://github.com/apache/spark/pull/29424
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29424: [MINOR][SQL] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-673953226
**[Test build #127448 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127448/testReport)** for PR 29424 at commit [`aab1e1a`](https://github.com/apache/spark/commit/aab1e1aea902619c87902cb9654527673a265bab).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29424: [MINOR] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-673496947
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29424: [SQL][MINOR] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-673756572
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127426/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29424: [MINOR] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-673755561
Looks okay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29424: [MINOR][SQL] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-674064635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29424: [MINOR][SQL] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-674063797
**[Test build #127448 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127448/testReport)** for PR 29424 at commit [`aab1e1a`](https://github.com/apache/spark/commit/aab1e1aea902619c87902cb9654527673a265bab).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29424: [SQL][MINOR] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-673756078
**[Test build #127426 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127426/testReport)** for PR 29424 at commit [`1a405a8`](https://github.com/apache/spark/commit/1a405a871c0377feff0f865d71ec306cf4b138c9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29424: [MINOR][SQL] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-673953626
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29424: [SQL][MINOR] Fixed approx_count_distinct rsd param description
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29424:
URL: https://github.com/apache/spark/pull/29424#issuecomment-673756557
**[Test build #127426 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127426/testReport)** for PR 29424 at commit [`1a405a8`](https://github.com/apache/spark/commit/1a405a871c0377feff0f865d71ec306cf4b138c9).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org