You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/26 22:56:41 UTC
[GitHub] [arrow] raduteo opened a new pull request #8537: ARROW-10400 Propagate TLS client peer_identity when using mutual TLS
raduteo opened a new pull request #8537:
URL: https://github.com/apache/arrow/pull/8537
https://issues.apache.org/jira/browse/ARROW-10400
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8537: ARROW-10400 Propagate TLS client peer_identity when using mutual TLS
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8537:
URL: https://github.com/apache/arrow/pull/8537#issuecomment-716872324
https://issues.apache.org/jira/browse/ARROW-10400
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #8537: ARROW-10400: [C++] Propagate TLS client peer_identity when using mutual TLS
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #8537:
URL: https://github.com/apache/arrow/pull/8537
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raduteo commented on pull request #8537: ARROW-10400: [C++] Propagate TLS client peer_identity when using mutual TLS
Posted by GitBox <gi...@apache.org>.
raduteo commented on pull request #8537:
URL: https://github.com/apache/arrow/pull/8537#issuecomment-717462766
> LGTM, thanks for this. Is it possible to test this? (There are some certs in the test data directory, but I'm not sure if they're usable with mTLS.)
I do agree and feel a bit dirty about it - there is no coverage or test support for the existing client side tls logic, I added a ticket on that https://issues.apache.org/jira/browse/ARROW-10404 and if you want to assign it to me, I will try to fix that soon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #8537: ARROW-10400: [C++] Propagate TLS client peer_identity when using mutual TLS
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #8537:
URL: https://github.com/apache/arrow/pull/8537#issuecomment-717492502
I went ahead and merged this (since the failures are due to LLVM dependencies).
I added you to Contributors in JIRA so you can self-assign issues now as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raduteo edited a comment on pull request #8537: ARROW-10400: [C++] Propagate TLS client peer_identity when using mutual TLS
Posted by GitBox <gi...@apache.org>.
raduteo edited a comment on pull request #8537:
URL: https://github.com/apache/arrow/pull/8537#issuecomment-717462766
> LGTM, thanks for this. Is it possible to test this? (There are some certs in the test data directory, but I'm not sure if they're usable with mTLS.)
I do agree and feel a bit dirty about it - there is no coverage or test support for the existing client side tls logic, I added a ticket on that https://issues.apache.org/jira/browse/ARROW-10404 and if you want to assign it to me, I will try to fix that soon
FWIW I did test it locally and it works and I generally don't think it can break any existing functionality
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org